Blind fix for uninitialized memory bug in ba9a7e3

alvherre · alvherre · commit 2d655a08d532 · 2022-03-20T22:10:24.000+01:00
Valgrind animal skink shows a crash in this new code.  I couldn't
reproduce the problem locally, but going by blind code inspection,
initializing insert_destrel should be sufficient to fix the problem.
diff --git a/src/backend/executor/nodeModifyTable.c b/src/backend/executor/nodeModifyTable.c
@@ -1820,7 +1820,7 @@ lreplace:;
 	if (partition_constraint_failed)
 	{
 		TupleTableSlot *inserted_tuple;
-		ResultRelInfo *insert_destrel;
+		ResultRelInfo *insert_destrel = NULL;
 
 		/*
 		 * ExecCrossPartitionUpdate will first DELETE the row from the

Original file line number	Diff line number	Diff line change
`@@ -1820,7 +1820,7 @@ lreplace:;`
`1820`	`1820`	`if (partition_constraint_failed)`
`1821`	`1821`	`{`
`1822`	`1822`	`TupleTableSlot *inserted_tuple;`
`1823`		`- ResultRelInfo *insert_destrel;`
	`1823`	`+ ResultRelInfo *insert_destrel = NULL;`
`1824`	`1824`
`1825`	`1825`	`/*`
`1826`	`1826`	`* ExecCrossPartitionUpdate will first DELETE the row from the`