Reorder identity regression test

petere · petere · commit 2fadf24e249b · 2019-03-15T00:21:30.000+01:00
The previous test order had the effect that if something was wrong
with the identity functionality, the create_table_like test would
likely fail or crash first, which is confusing.  Reorder so that the
identity test comes before create_table_like.
diff --git a/src/test/regress/expected/identity.out b/src/test/regress/expected/identity.out
@@ -250,6 +250,7 @@ SELECT * FROM itestv11;
  11 | xyz
 (3 rows)
 
+DROP VIEW itestv10, itestv11;
 -- ADD COLUMN
 CREATE TABLE itest13 (a int);
 -- add column to empty table
diff --git a/src/test/regress/expected/sanity_check.out b/src/test/regress/expected/sanity_check.out
@@ -57,8 +57,6 @@ hash_txt_heap|t
 hobbies_r|f
 ihighway|t
 inet_tbl|f
-inhf|f
-inhx|t
 insert_tbl|f
 int2_tbl|f
 int4_tbl|f
diff --git a/src/test/regress/parallel_schedule b/src/test/regress/parallel_schedule
@@ -60,7 +60,7 @@ test: create_index create_view index_including index_including_gist
 # ----------
 # Another group of parallel tests
 # ----------
-test: create_aggregate create_function_3 create_cast constraints triggers inherit create_table_like typed_table vacuum drop_if_exists updatable_views rolenames roleattributes create_am hash_func
+test: create_aggregate create_function_3 create_cast constraints triggers inherit typed_table vacuum drop_if_exists updatable_views rolenames roleattributes create_am hash_func
 
 # ----------
 # sanity_check does a vacuum, affecting the sort order of SELECT *
@@ -84,12 +84,12 @@ test: select_into select_distinct select_distinct_on select_implicit select_havi
 # ----------
 # Another group of parallel tests
 # ----------
-test: brin gin gist spgist privileges init_privs security_label collate matview lock replica_identity rowsecurity object_address tablesample groupingsets drop_operator password
+test: brin gin gist spgist privileges init_privs security_label collate matview lock replica_identity rowsecurity object_address tablesample groupingsets drop_operator password identity
 
 # ----------
 # Another group of parallel tests
 # ----------
-test: alter_generic alter_operator misc psql async dbsize misc_functions sysviews tsrf tidscan stats_ext
+test: create_table_like alter_generic alter_operator misc psql async dbsize misc_functions sysviews tsrf tidscan stats_ext
 
 # rules cannot run concurrently with any test that creates a view
 test: rules psql_crosstab amutils
@@ -116,7 +116,7 @@ test: plancache limit plpgsql copy2 temp domain rangefuncs prepare conversion tr
 # ----------
 # Another group of parallel tests
 # ----------
-test: identity partition_join partition_prune reloptions hash_part indexing partition_aggregate partition_info
+test: partition_join partition_prune reloptions hash_part indexing partition_aggregate partition_info
 
 # event triggers cannot run concurrently with any test that runs DDL
 test: event_trigger
diff --git a/src/test/regress/serial_schedule b/src/test/regress/serial_schedule
@@ -72,7 +72,6 @@ test: create_cast
 test: constraints
 test: triggers
 test: inherit
-test: create_table_like
 test: typed_table
 test: vacuum
 test: drop_if_exists
@@ -122,6 +121,8 @@ test: tablesample
 test: groupingsets
 test: drop_operator
 test: password
+test: identity
+test: create_table_like
 test: alter_generic
 test: alter_operator
 test: misc
@@ -178,7 +179,6 @@ test: returning
 test: largeobject
 test: with
 test: xml
-test: identity
 test: partition_join
 test: partition_prune
 test: reloptions
diff --git a/src/test/regress/sql/identity.sql b/src/test/regress/sql/identity.sql
@@ -145,6 +145,8 @@ INSERT INTO itestv11 OVERRIDING SYSTEM VALUE VALUES (11, 'xyz');
 
 SELECT * FROM itestv11;
 
+DROP VIEW itestv10, itestv11;
+
 
 -- ADD COLUMN
 
