Fix security definer functions with polymorphic arguments. This case has

tglsfdc · tglsfdc · commit 310578efee21 · 2007-07-31T15:49:49.000Z
never worked because fmgr_security_definer() neglected to pass the fn_expr
information through.  Per report from Viatcheslav Kalinin.
diff --git a/src/backend/utils/fmgr/fmgr.c b/src/backend/utils/fmgr/fmgr.c
@@ -8,7 +8,7 @@
  *
  *
  * IDENTIFICATION
- *	  $PostgreSQL: pgsql/src/backend/utils/fmgr/fmgr.c,v 1.107 2007/07/13 02:25:48 tgl Exp $
+ *	  $PostgreSQL: pgsql/src/backend/utils/fmgr/fmgr.c,v 1.108 2007/07/31 15:49:49 tgl Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -859,6 +859,7 @@ fmgr_security_definer(PG_FUNCTION_ARGS)
 
 		fmgr_info_cxt_security(fcinfo->flinfo->fn_oid, &fcache->flinfo,
 							   fcinfo->flinfo->fn_mcxt, true);
+		fcache->flinfo.fn_expr = fcinfo->flinfo->fn_expr;
 
 		tuple = SearchSysCache(PROCOID,
 							   ObjectIdGetDatum(fcinfo->flinfo->fn_oid),

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`*`
`9`	`9`	`*`
`10`	`10`	`* IDENTIFICATION`
`11`		`- * $PostgreSQL: pgsql/src/backend/utils/fmgr/fmgr.c,v 1.107 2007/07/13 02:25:48 tgl Exp $`
	`11`	`+ * $PostgreSQL: pgsql/src/backend/utils/fmgr/fmgr.c,v 1.108 2007/07/31 15:49:49 tgl Exp $`
`12`	`12`	`*`
`13`	`13`	`*-------------------------------------------------------------------------`
`14`	`14`	`*/`
`@@ -859,6 +859,7 @@ fmgr_security_definer(PG_FUNCTION_ARGS)`
`859`	`859`
`860`	`860`	`fmgr_info_cxt_security(fcinfo->flinfo->fn_oid, &fcache->flinfo,`
`861`	`861`	`fcinfo->flinfo->fn_mcxt, true);`
	`862`	`+ fcache->flinfo.fn_expr = fcinfo->flinfo->fn_expr;`
`862`	`863`
`863`	`864`	`tuple = SearchSysCache(PROCOID,`
`864`	`865`	`ObjectIdGetDatum(fcinfo->flinfo->fn_oid),`