Fix -Wmissing-variable-declarations warnings for float.c special case

petere · petere · commit 37c6923cf3d8 · 2024-07-25T10:40:04.000+02:00
This adds extern declarations for the global variables defined in float.c but not meant for external use. This is a workaround to be able to add -Wmissing-variable-declarations to the global set of warning options in the near future. Reviewed-by: Andres Freund <andres@anarazel.de> Discussion: https://www.postgresql.org/message-id/flat/e0a62134-83da-4ba4-8cdb-ceb0111c95ce@eisentraut.org
diff --git a/src/backend/utils/adt/float.c b/src/backend/utils/adt/float.c
@@ -55,7 +55,15 @@ static float8 cot_45 = 0;
  * be referenced by other files, much less changed; but we don't want the
  * compiler to know that, else it might try to precompute expressions
  * involving them.  See comments for init_degree_constants().
- */
+ *
+ * The additional extern declarations are to silence
+ * -Wmissing-variable-declarations.
+ */
+extern float8 degree_c_thirty;
+extern float8 degree_c_forty_five;
+extern float8 degree_c_sixty;
+extern float8 degree_c_one_half;
+extern float8 degree_c_one;
 float8		degree_c_thirty = 30.0;
 float8		degree_c_forty_five = 45.0;
 float8		degree_c_sixty = 60.0;
