Skip to content

Commit 383f222

Browse files
committed
Try to stabilize vacuum test.
As commits b700f96 and 3414099 did for the reloptions test, make sure VACUUM can always truncate the table as expected. Back-patch to 12, where vacuum_truncate arrived. Discussion: https://postgr.es/m/CAD21AoCNoWjYkdEtr%2BVDoF9v__V905AedKZ9iF%3DArgCtrbxZqw%40mail.gmail.com
1 parent 5b29a9f commit 383f222

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

src/test/regress/expected/vacuum.out

+3-3
Original file line numberDiff line numberDiff line change
@@ -165,19 +165,19 @@ VACUUM (INDEX_CLEANUP FALSE) vaccluster;
165165
VACUUM (INDEX_CLEANUP AUTO) vactst; -- index cleanup option is ignored if no indexes
166166
VACUUM (INDEX_CLEANUP FALSE, FREEZE TRUE) vaccluster;
167167
-- TRUNCATE option
168-
CREATE TABLE vac_truncate_test(i INT NOT NULL, j text)
168+
CREATE TEMP TABLE vac_truncate_test(i INT NOT NULL, j text)
169169
WITH (vacuum_truncate=true, autovacuum_enabled=false);
170170
INSERT INTO vac_truncate_test VALUES (1, NULL), (NULL, NULL);
171171
ERROR: null value in column "i" of relation "vac_truncate_test" violates not-null constraint
172172
DETAIL: Failing row contains (null, null).
173-
VACUUM (TRUNCATE FALSE) vac_truncate_test;
173+
VACUUM (TRUNCATE FALSE, DISABLE_PAGE_SKIPPING) vac_truncate_test;
174174
SELECT pg_relation_size('vac_truncate_test') > 0;
175175
?column?
176176
----------
177177
t
178178
(1 row)
179179

180-
VACUUM vac_truncate_test;
180+
VACUUM (DISABLE_PAGE_SKIPPING) vac_truncate_test;
181181
SELECT pg_relation_size('vac_truncate_test') = 0;
182182
?column?
183183
----------

src/test/regress/sql/vacuum.sql

+3-3
Original file line numberDiff line numberDiff line change
@@ -147,12 +147,12 @@ VACUUM (INDEX_CLEANUP AUTO) vactst; -- index cleanup option is ignored if no ind
147147
VACUUM (INDEX_CLEANUP FALSE, FREEZE TRUE) vaccluster;
148148

149149
-- TRUNCATE option
150-
CREATE TABLE vac_truncate_test(i INT NOT NULL, j text)
150+
CREATE TEMP TABLE vac_truncate_test(i INT NOT NULL, j text)
151151
WITH (vacuum_truncate=true, autovacuum_enabled=false);
152152
INSERT INTO vac_truncate_test VALUES (1, NULL), (NULL, NULL);
153-
VACUUM (TRUNCATE FALSE) vac_truncate_test;
153+
VACUUM (TRUNCATE FALSE, DISABLE_PAGE_SKIPPING) vac_truncate_test;
154154
SELECT pg_relation_size('vac_truncate_test') > 0;
155-
VACUUM vac_truncate_test;
155+
VACUUM (DISABLE_PAGE_SKIPPING) vac_truncate_test;
156156
SELECT pg_relation_size('vac_truncate_test') = 0;
157157
VACUUM (TRUNCATE FALSE, FULL TRUE) vac_truncate_test;
158158
DROP TABLE vac_truncate_test;

0 commit comments

Comments
 (0)