Fix assorted inconsistent function declarations.

tglsfdc · tglsfdc · commit 393de3a09868 · 2015-04-07T16:56:21.000-04:00
While gcc doesn't complain if you declare a function "static" and then
define it not-static, other compilers do; and in any case the code is
highly misleading this way.  Add the missing "static" keywords to a
couple of recent patches.  Per buildfarm member pademelon.
diff --git a/src/bin/pg_rewind/parsexlog.c b/src/bin/pg_rewind/parsexlog.c
@@ -229,7 +229,7 @@ findLastCheckpoint(const char *datadir, XLogRecPtr forkptr, TimeLineID tli,
 }
 
 /* XLogreader callback function, to read a WAL page */
-int
+static int
 SimpleXLogPageRead(XLogReaderState *xlogreader, XLogRecPtr targetPagePtr,
 				   int reqLen, XLogRecPtr targetRecPtr, char *readBuf,
 				   TimeLineID *pageTLI)

Original file line number	Diff line number	Diff line change
`@@ -229,7 +229,7 @@ findLastCheckpoint(const char *datadir, XLogRecPtr forkptr, TimeLineID tli,`
`229`	`229`	`}`
`230`	`230`
`231`	`231`	`/* XLogreader callback function, to read a WAL page */`
`232`		`-int`
	`232`	`+static int`
`233`	`233`	`SimpleXLogPageRead(XLogReaderState *xlogreader, XLogRecPtr targetPagePtr,`
`234`	`234`	`int reqLen, XLogRecPtr targetRecPtr, char *readBuf,`
`235`	`235`	`TimeLineID *pageTLI)`