Check for stack overrun in standard_ProcessUtility().

tglsfdc · tglsfdc · commit 3a60c8bb1698 · 2018-10-15T14:01:38.000-04:00
ProcessUtility can recurse, and indeed can be driven to infinite recursion, so it ought to have a check_stack_depth() call. This covers the reported bug (portal trying to execute itself) and a bunch of other cases that could perhaps arise somewhere. Per bug #15428 from Malthe Borch. Back-patch to all supported branches. Discussion: https://postgr.es/m/15428-b3c2915ec470b033@postgresql.org
diff --git a/src/backend/tcop/utility.c b/src/backend/tcop/utility.c
@@ -332,6 +332,9 @@ standard_ProcessUtility(Node *parsetree,
 {
 	bool		isTopLevel = (context == PROCESS_UTILITY_TOPLEVEL);
 
+	/* This can recurse, so check for excessive recursion */
+	check_stack_depth();
+
 	check_xact_readonly(parsetree);
 
 	if (completionTag)

Original file line number	Diff line number	Diff line change
`@@ -332,6 +332,9 @@ standard_ProcessUtility(Node *parsetree,`
`332`	`332`	`{`
`333`	`333`	`bool isTopLevel = (context == PROCESS_UTILITY_TOPLEVEL);`
`334`	`334`
	`335`	`+ /* This can recurse, so check for excessive recursion */`
	`336`	`+ check_stack_depth();`
	`337`	`+`
`335`	`338`	`check_xact_readonly(parsetree);`
`336`	`339`
`337`	`340`	`if (completionTag)`