Small code simplification

petere · petere · commit 3b7cd8c690f2 · 2023-03-16T15:33:43.000+01:00
Author: Nathan Bossart <nathandbossart@gmail.com> Discussion: https://www.postgresql.org/message-id/20230310000313.GA3992372%40nathanxps13
diff --git a/src/backend/commands/user.c b/src/backend/commands/user.c
@@ -1378,7 +1378,7 @@ RenameRole(const char *oldname, const char *newname)
 	 * Only superusers can mess with superusers. Otherwise, a user with
 	 * CREATEROLE can rename a role for which they have ADMIN OPTION.
 	 */
-	if (((Form_pg_authid) GETSTRUCT(oldtuple))->rolsuper)
+	if (authform->rolsuper)
 	{
 		if (!superuser())
 			ereport(ERROR,

Original file line number	Diff line number	Diff line change
`@@ -1378,7 +1378,7 @@ RenameRole(const char oldname, const char newname)`
`1378`	`1378`	`* Only superusers can mess with superusers. Otherwise, a user with`
`1379`	`1379`	`* CREATEROLE can rename a role for which they have ADMIN OPTION.`
`1380`	`1380`	`*/`
`1381`		`- if (((Form_pg_authid) GETSTRUCT(oldtuple))->rolsuper)`
	`1381`	`+ if (authform->rolsuper)`
`1382`	`1382`	`{`
`1383`	`1383`	`if (!superuser())`
`1384`	`1384`	`ereport(ERROR,`