Wait for subscription to sync in t/031_column_list.sql

tvondra · tvondra · commit 404f49338fef · 2022-03-27T00:11:38.000+01:00
One of the TAP tests added in 923def9 did not wait after creating a subscription, and wait_for_catchup is not sufficient for this. So if the tablesync workers happen do not complete quickly enough, the test won't see the expected results. This probably explains intermittent failures on a couple buildfarm animals (komodoensis, petalura and snapper). Reported-by: Tom Lane Discussion: https://postgr.es/m/170549.1648330634@sss.pgh.pa.us
diff --git a/src/test/subscription/t/031_column_list.pl b/src/test/subscription/t/031_column_list.pl
@@ -722,7 +722,7 @@ sub wait_for_subscription_sync
 	CREATE SUBSCRIPTION sub1 CONNECTION '$publisher_connstr' PUBLICATION pub8;
 ));
 
-$node_publisher->wait_for_catchup('sub1');
+wait_for_subscription_sync($node_subscriber);
 
 $node_publisher->safe_psql('postgres', qq(
 	INSERT INTO test_part_c VALUES (3, 7, 8);
