Fix two bugs in change_owner_recurse_to_sequences: it was grabbing an

tglsfdc · tglsfdc · commit 410fede0dd8e · 2005-03-25T18:04:34.000Z
overly strong lock on pg_depend, and it wasn't closing the rel when done.
The latter bug was masked by the ResourceOwner code, which is something
that should be changed.
diff --git a/src/backend/commands/tablecmds.c b/src/backend/commands/tablecmds.c
@@ -8,7 +8,7 @@
  *
  *
  * IDENTIFICATION
- *	  $PostgreSQL: pgsql/src/backend/commands/tablecmds.c,v 1.150 2005/03/24 00:03:22 neilc Exp $
+ *	  $PostgreSQL: pgsql/src/backend/commands/tablecmds.c,v 1.151 2005/03/25 18:04:34 tgl Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -5374,7 +5374,7 @@ change_owner_recurse_to_sequences(Oid relationOid, int32 newOwnerSysId)
 	 * SERIAL sequences are those having an internal dependency on one
 	 * of the table's columns (we don't care *which* column, exactly).
 	 */
-	depRel = heap_openr(DependRelationName, RowExclusiveLock);
+	depRel = heap_openr(DependRelationName, AccessShareLock);
 
 	ScanKeyInit(&key[0],
 			Anum_pg_depend_refclassid,
@@ -5420,6 +5420,8 @@ change_owner_recurse_to_sequences(Oid relationOid, int32 newOwnerSysId)
 	}
 
 	systable_endscan(scan);
+
+	relation_close(depRel, AccessShareLock);
 }
 
 /*

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`*`
`9`	`9`	`*`
`10`	`10`	`* IDENTIFICATION`
`11`		`- * $PostgreSQL: pgsql/src/backend/commands/tablecmds.c,v 1.150 2005/03/24 00:03:22 neilc Exp $`
	`11`	`+ * $PostgreSQL: pgsql/src/backend/commands/tablecmds.c,v 1.151 2005/03/25 18:04:34 tgl Exp $`
`12`	`12`	`*`
`13`	`13`	`*-------------------------------------------------------------------------`
`14`	`14`	`*/`
`@@ -5374,7 +5374,7 @@ change_owner_recurse_to_sequences(Oid relationOid, int32 newOwnerSysId)`
`5374`	`5374`	`* SERIAL sequences are those having an internal dependency on one`
`5375`	`5375`	`* of the table's columns (we don't care which column, exactly).`
`5376`	`5376`	`*/`
`5377`		`- depRel = heap_openr(DependRelationName, RowExclusiveLock);`
	`5377`	`+ depRel = heap_openr(DependRelationName, AccessShareLock);`
`5378`	`5378`
`5379`	`5379`	`ScanKeyInit(&key[0],`
`5380`	`5380`	`Anum_pg_depend_refclassid,`
`@@ -5420,6 +5420,8 @@ change_owner_recurse_to_sequences(Oid relationOid, int32 newOwnerSysId)`
`5420`	`5420`	`}`
`5421`	`5421`
`5422`	`5422`	`systable_endscan(scan);`
	`5423`	`+`
	`5424`	`+ relation_close(depRel, AccessShareLock);`
`5423`	`5425`	`}`
`5424`	`5426`
`5425`	`5427`	`/*`