Update TransactionXmin when MyProc->xmin is updated

hlinnaka · hlinnaka · commit 41eafbb494c9 · 2024-12-21T23:42:59.000+02:00
GetSnapshotData() set TransactionXmin = MyProc->xmin, but when SnapshotResetXmin() advanced MyProc->xmin, it did not advance TransactionXmin correspondingly. That meant that TransactionXmin could be older than MyProc->xmin, and XIDs between than TransactionXmin and the real MyProc->xmin could be vacuumed away. One known consequence is in pg_subtrans lookups: we might try to look up the status of an XID that was already truncated away. Back-patch to all supported versions. Reviewed-by: Andres Freund Discussion: https://www.postgresql.org/message-id/d27a046d-a1e4-47d1-a95c-fbabe41debb4@iki.fi
diff --git a/src/backend/utils/time/snapmgr.c b/src/backend/utils/time/snapmgr.c
@@ -948,15 +948,15 @@ SnapshotResetXmin(void)
 
 	if (pairingheap_is_empty(&RegisteredSnapshots))
 	{
-		MyProc->xmin = InvalidTransactionId;
+		MyProc->xmin = TransactionXmin = InvalidTransactionId;
 		return;
 	}
 
 	minSnapshot = pairingheap_container(SnapshotData, ph_node,
 										pairingheap_first(&RegisteredSnapshots));
 
 	if (TransactionIdPrecedes(MyProc->xmin, minSnapshot->xmin))
-		MyProc->xmin = minSnapshot->xmin;
+		MyProc->xmin = TransactionXmin = minSnapshot->xmin;
 }
 
 /*

Original file line number	Diff line number	Diff line change
`@@ -948,15 +948,15 @@ SnapshotResetXmin(void)`
`948`	`948`
`949`	`949`	`if (pairingheap_is_empty(&RegisteredSnapshots))`
`950`	`950`	`{`
`951`		`- MyProc->xmin = InvalidTransactionId;`
	`951`	`+ MyProc->xmin = TransactionXmin = InvalidTransactionId;`
`952`	`952`	`return;`
`953`	`953`	`}`
`954`	`954`
`955`	`955`	`minSnapshot = pairingheap_container(SnapshotData, ph_node,`
`956`	`956`	`pairingheap_first(&RegisteredSnapshots));`
`957`	`957`
`958`	`958`	`if (TransactionIdPrecedes(MyProc->xmin, minSnapshot->xmin))`
`959`		`- MyProc->xmin = minSnapshot->xmin;`
	`959`	`+ MyProc->xmin = TransactionXmin = minSnapshot->xmin;`
`960`	`960`	`}`
`961`	`961`
`962`	`962`	`/*`