tests: Cope with WARNINGs during failed CREATE DB on windows

anarazel · anarazel · commit 43dca8a11624 · 2025-04-02T07:51:48.000-04:00
The test added in 93bc3d7 sometimes fails on windows, due to warnings like WARNING: some useless files may be left behind in old database directory "base/16514" The reason for that is createdb_failure_callback() does not ensure that there are no open file descriptors for files in the partially created, to-be-dropped, database. We do take care in dropdb(), but that involves waiting for checkpoints and a ProcSignalBarrier, which we probably don't want to do in an error callback. This should probably be fixed one day, but for now 001_aio.pl needs to cope. Per buildfarm animals fairywren and drongo. Discussion: https://postgr.es/m/uc62i6vi5gd4bi6wtjj5poadqxolgy55e7ihkmf3mthjegb6zl@zqo7xez7sc2r
diff --git a/src/test/modules/test_aio/t/001_aio.pl b/src/test/modules/test_aio/t/001_aio.pl
@@ -1279,6 +1279,11 @@ sub test_checksum_createdb
 
 	# Verify that CREATE DATABASE of an invalid database fails and is
 	# accounted for accurately.
+	#
+	# Note: On windows additional WARNING messages might be printed, due to
+	# "some useless files may be left behind" warnings. While we probably
+	# should prevent those from occurring, they're independent of AIO, so we
+	# shouldn't fail because of them here.
 	my ($cs_count_before, $cs_ts_before) =
 	  checksum_failures($psql, 'regression_createdb_source');
 	psql_like(
@@ -1287,7 +1292,7 @@ sub test_checksum_createdb
 		"create database w/ wal strategy, invalid source",
 		$createdb_sql,
 		qr/^$/,
-		qr/^psql:<stdin>:\d+: ERROR:  invalid page in block 1 of relation base\/\d+\/\d+$/
+		qr/psql:<stdin>:\d+: ERROR:  invalid page in block 1 of relation base\/\d+\/\d+$/
 	);
 	my ($cs_count_after, $cs_ts_after) =
 	  checksum_failures($psql, 'regression_createdb_source');
