Skip to content

Commit 44ba3f5

Browse files
nmischnmisch
committed
With GB18030, prevent SIGSEGV from reading past end of allocation.
With GB18030 as source encoding, applications could crash the server via SQL functions convert() or convert_from(). Applications themselves could crash after passing unterminated GB18030 input to libpq functions PQescapeLiteral(), PQescapeIdentifier(), PQescapeStringConn(), or PQescapeString(). Extension code could crash by passing unterminated GB18030 input to jsonapi.h functions. All those functions have been intended to handle untrusted, unterminated input safely. A crash required allocating the input such that the last byte of the allocation was the last byte of a virtual memory page. Some malloc() implementations take measures against that, making the SIGSEGV hard to reach. Back-patch to v13 (all supported versions). Author: Noah Misch <noah@leadboat.com> Author: Andres Freund <andres@anarazel.de> Reviewed-by: Masahiko Sawada <sawada.mshk@gmail.com> Backpatch-through: 13 Security: CVE-2025-4207
1 parent 45fe7e0 commit 44ba3f5

File tree

9 files changed

+188
-30
lines changed

9 files changed

+188
-30
lines changed

‎src/backend/utils/mb/mbutils.c

Lines changed: 13 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1030,7 +1030,7 @@ pg_mbcliplen(const char *mbstr, int len, int limit)
10301030
}
10311031

10321032
/*
1033-
* pg_mbcliplen with specified encoding
1033+
* pg_mbcliplen with specified encoding; string must be valid in encoding
10341034
*/
10351035
int
10361036
pg_encoding_mbcliplen(int encoding, const char *mbstr,
@@ -1641,12 +1641,12 @@ check_encoding_conversion_args(int src_encoding,
16411641
* report_invalid_encoding: complain about invalid multibyte character
16421642
*
16431643
* note: len is remaining length of string, not length of character;
1644-
* len must be greater than zero, as we always examine the first byte.
1644+
* len must be greater than zero (or we'd neglect initializing "buf").
16451645
*/
16461646
void
16471647
report_invalid_encoding(int encoding, const char *mbstr, int len)
16481648
{
1649-
int l = pg_encoding_mblen(encoding, mbstr);
1649+
int l = pg_encoding_mblen_or_incomplete(encoding, mbstr, len);
16501650
char buf[8 * 5 + 1];
16511651
char *p = buf;
16521652
int j,
@@ -1673,18 +1673,26 @@ report_invalid_encoding(int encoding, const char *mbstr, int len)
16731673
* report_untranslatable_char: complain about untranslatable character
16741674
*
16751675
* note: len is remaining length of string, not length of character;
1676-
* len must be greater than zero, as we always examine the first byte.
1676+
* len must be greater than zero (or we'd neglect initializing "buf").
16771677
*/
16781678
void
16791679
report_untranslatable_char(int src_encoding, int dest_encoding,
16801680
const char *mbstr, int len)
16811681
{
1682-
int l = pg_encoding_mblen(src_encoding, mbstr);
1682+
int l;
16831683
char buf[8 * 5 + 1];
16841684
char *p = buf;
16851685
int j,
16861686
jlimit;
16871687

1688+
/*
1689+
* We probably could use plain pg_encoding_mblen(), because
1690+
* gb18030_to_utf8() verifies before it converts. All conversions should.
1691+
* For src_encoding!=GB18030, len>0 meets pg_encoding_mblen() needs. Even
1692+
* so, be defensive, since a buggy conversion might pass invalid data.
1693+
* This is not a performance-critical path.
1694+
*/
1695+
l = pg_encoding_mblen_or_incomplete(src_encoding, mbstr, len);
16881696
jlimit = Min(l, len);
16891697
jlimit = Min(jlimit, 8); /* prevent buffer overrun */
16901698

‎src/common/jsonapi.c

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -692,8 +692,11 @@ json_lex_string(JsonLexContext *lex)
692692
} while (0)
693693
#define FAIL_AT_CHAR_END(code) \
694694
do { \
695-
char *term = s + pg_encoding_mblen(lex->input_encoding, s); \
696-
lex->token_terminator = (term <= end) ? term : end; \
695+
ptrdiff_t remaining = end - s; \
696+
int charlen; \
697+
charlen = pg_encoding_mblen_or_incomplete(lex->input_encoding, \
698+
s, remaining); \
699+
lex->token_terminator = (charlen <= remaining) ? s + charlen : end; \
697700
return code; \
698701
} while (0)
699702

‎src/common/wchar.c

Lines changed: 45 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,8 @@
1212
*/
1313
#include "c.h"
1414

15+
#include <limits.h>
16+
1517
#include "mb/pg_wchar.h"
1618
#include "utils/ascii.h"
1719

@@ -2168,10 +2170,27 @@ const pg_wchar_tbl pg_wchar_table[] = {
21682170
/*
21692171
* Returns the byte length of a multibyte character.
21702172
*
2171-
* Caution: when dealing with text that is not certainly valid in the
2172-
* specified encoding, the result may exceed the actual remaining
2173-
* string length. Callers that are not prepared to deal with that
2174-
* should use pg_encoding_mblen_bounded() instead.
2173+
* Choose "mblen" functions based on the input string characteristics.
2174+
* pg_encoding_mblen() can be used when ANY of these conditions are met:
2175+
*
2176+
* - The input string is zero-terminated
2177+
*
2178+
* - The input string is known to be valid in the encoding (e.g., string
2179+
* converted from database encoding)
2180+
*
2181+
* - The encoding is not GB18030 (e.g., when only database encodings are
2182+
* passed to 'encoding' parameter)
2183+
*
2184+
* encoding==GB18030 requires examining up to two bytes to determine character
2185+
* length. Therefore, callers satisfying none of those conditions must use
2186+
* pg_encoding_mblen_or_incomplete() instead, as access to mbstr[1] cannot be
2187+
* guaranteed to be within allocation bounds.
2188+
*
2189+
* When dealing with text that is not certainly valid in the specified
2190+
* encoding, the result may exceed the actual remaining string length.
2191+
* Callers that are not prepared to deal with that should use Min(remaining,
2192+
* pg_encoding_mblen_or_incomplete()). For zero-terminated strings, that and
2193+
* pg_encoding_mblen_bounded() are interchangeable.
21752194
*/
21762195
int
21772196
pg_encoding_mblen(int encoding, const char *mbstr)
@@ -2182,8 +2201,28 @@ pg_encoding_mblen(int encoding, const char *mbstr)
21822201
}
21832202

21842203
/*
2185-
* Returns the byte length of a multibyte character; but not more than
2186-
* the distance to end of string.
2204+
* Returns the byte length of a multibyte character (possibly not
2205+
* zero-terminated), or INT_MAX if too few bytes remain to determine a length.
2206+
*/
2207+
int
2208+
pg_encoding_mblen_or_incomplete(int encoding, const char *mbstr,
2209+
size_t remaining)
2210+
{
2211+
/*
2212+
* Define zero remaining as too few, even for single-byte encodings.
2213+
* pg_gb18030_mblen() reads one or two bytes; single-byte encodings read
2214+
* zero; others read one.
2215+
*/
2216+
if (remaining < 1 ||
2217+
(encoding == PG_GB18030 && IS_HIGHBIT_SET(*mbstr) && remaining < 2))
2218+
return INT_MAX;
2219+
return pg_encoding_mblen(encoding, mbstr);
2220+
}
2221+
2222+
/*
2223+
* Returns the byte length of a multibyte character; but not more than the
2224+
* distance to the terminating zero byte. For input that might lack a
2225+
* terminating zero, use Min(remaining, pg_encoding_mblen_or_incomplete()).
21872226
*/
21882227
int
21892228
pg_encoding_mblen_bounded(int encoding, const char *mbstr)

‎src/include/mb/pg_wchar.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -575,6 +575,8 @@ extern int pg_valid_server_encoding_id(int encoding);
575575
*/
576576
extern void pg_encoding_set_invalid(int encoding, char *dst);
577577
extern int pg_encoding_mblen(int encoding, const char *mbstr);
578+
extern int pg_encoding_mblen_or_incomplete(int encoding, const char *mbstr,
579+
size_t remaining);
578580
extern int pg_encoding_mblen_bounded(int encoding, const char *mbstr);
579581
extern int pg_encoding_dsplen(int encoding, const char *mbstr);
580582
extern int pg_encoding_verifymbchar(int encoding, const char *mbstr, int len);

‎src/interfaces/libpq/fe-exec.c

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4003,7 +4003,8 @@ PQescapeStringInternal(PGconn *conn,
40034003
}
40044004

40054005
/* Slow path for possible multibyte characters */
4006-
charlen = pg_encoding_mblen(encoding, source);
4006+
charlen = pg_encoding_mblen_or_incomplete(encoding,
4007+
source, remaining);
40074008

40084009
if (remaining < charlen ||
40094010
pg_encoding_verifymbchar(encoding, source, charlen) == -1)
@@ -4149,7 +4150,8 @@ PQescapeInternal(PGconn *conn, const char *str, size_t len, bool as_ident)
41494150
int charlen;
41504151

41514152
/* Slow path for possible multibyte characters */
4152-
charlen = pg_encoding_mblen(conn->client_encoding, s);
4153+
charlen = pg_encoding_mblen_or_incomplete(conn->client_encoding,
4154+
s, remaining);
41534155

41544156
if (charlen > remaining)
41554157
{

‎src/interfaces/libpq/fe-misc.c

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1173,13 +1173,9 @@ pqSocketPoll(int sock, int forRead, int forWrite, time_t end_time)
11731173
*/
11741174

11751175
/*
1176-
* Returns the byte length of the character beginning at s, using the
1177-
* specified encoding.
1178-
*
1179-
* Caution: when dealing with text that is not certainly valid in the
1180-
* specified encoding, the result may exceed the actual remaining
1181-
* string length. Callers that are not prepared to deal with that
1182-
* should use PQmblenBounded() instead.
1176+
* Like pg_encoding_mblen(). Use this in callers that want the
1177+
* dynamically-linked libpq's stance on encodings, even if that means
1178+
* different behavior in different startups of the executable.
11831179
*/
11841180
int
11851181
PQmblen(const char *s, int encoding)
@@ -1188,8 +1184,9 @@ PQmblen(const char *s, int encoding)
11881184
}
11891185

11901186
/*
1191-
* Returns the byte length of the character beginning at s, using the
1192-
* specified encoding; but not more than the distance to end of string.
1187+
* Like pg_encoding_mblen_bounded(). Use this in callers that want the
1188+
* dynamically-linked libpq's stance on encodings, even if that means
1189+
* different behavior in different startups of the executable.
11931190
*/
11941191
int
11951192
PQmblenBounded(const char *s, int encoding)

‎src/test/modules/test_escape/test_escape.c

Lines changed: 99 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
#include <string.h>
1313
#include <stdio.h>
1414

15+
#include "common/jsonapi.h"
1516
#include "fe_utils/psqlscan.h"
1617
#include "fe_utils/string_utils.h"
1718
#include "getopt_long.h"
@@ -164,6 +165,91 @@ encoding_conflicts_ascii(int encoding)
164165
}
165166

166167

168+
/*
169+
* Confirm escaping doesn't read past the end of an allocation. Consider the
170+
* result of malloc(4096), in the absence of freelist entries satisfying the
171+
* allocation. On OpenBSD, reading one byte past the end of that object
172+
* yields SIGSEGV.
173+
*
174+
* Run this test before the program's other tests, so freelists are minimal.
175+
* len=4096 didn't SIGSEGV, likely due to free() calls in libpq. len=8192
176+
* did. Use 128 KiB, to somewhat insulate the outcome from distant new free()
177+
* calls and libc changes.
178+
*/
179+
static void
180+
test_gb18030_page_multiple(pe_test_config *tc)
181+
{
182+
PQExpBuffer testname;
183+
size_t input_len = 0x20000;
184+
char *input;
185+
186+
/* prepare input */
187+
input = pg_malloc(input_len);
188+
memset(input, '-', input_len - 1);
189+
input[input_len - 1] = 0xfe;
190+
191+
/* name to describe the test */
192+
testname = createPQExpBuffer();
193+
appendPQExpBuffer(testname, ">repeat(%c, %zu)", input[0], input_len - 1);
194+
escapify(testname, input + input_len - 1, 1);
195+
appendPQExpBuffer(testname, "< - GB18030 - PQescapeLiteral");
196+
197+
/* test itself */
198+
PQsetClientEncoding(tc->conn, "GB18030");
199+
report_result(tc, PQescapeLiteral(tc->conn, input, input_len) == NULL,
200+
testname->data, "",
201+
"input validity vs escape success", "ok");
202+
203+
destroyPQExpBuffer(testname);
204+
pg_free(input);
205+
}
206+
207+
/*
208+
* Confirm json parsing doesn't read past the end of an allocation. This
209+
* exercises wchar.c infrastructure like the true "escape" tests do, but this
210+
* isn't an "escape" test.
211+
*/
212+
static void
213+
test_gb18030_json(pe_test_config *tc)
214+
{
215+
PQExpBuffer raw_buf;
216+
PQExpBuffer testname;
217+
const char input[] = "{\"\\u\xFE";
218+
size_t input_len = sizeof(input) - 1;
219+
JsonLexContext *lex;
220+
JsonSemAction sem = {0}; /* no callbacks */
221+
JsonParseErrorType json_error;
222+
char *error_str;
223+
224+
/* prepare input like test_one_vector_escape() does */
225+
raw_buf = createPQExpBuffer();
226+
appendBinaryPQExpBuffer(raw_buf, input, input_len);
227+
appendPQExpBufferStr(raw_buf, NEVER_ACCESS_STR);
228+
VALGRIND_MAKE_MEM_NOACCESS(&raw_buf->data[input_len],
229+
raw_buf->len - input_len);
230+
231+
/* name to describe the test */
232+
testname = createPQExpBuffer();
233+
appendPQExpBuffer(testname, ">");
234+
escapify(testname, input, input_len);
235+
appendPQExpBuffer(testname, "< - GB18030 - pg_parse_json");
236+
237+
/* test itself */
238+
lex = makeJsonLexContextCstringLen(raw_buf->data, input_len,
239+
PG_GB18030, false);
240+
json_error = pg_parse_json(lex, &sem);
241+
error_str = psprintf("JsonParseErrorType %d", json_error);
242+
report_result(tc, json_error == JSON_UNICODE_ESCAPE_FORMAT,
243+
testname->data, "",
244+
"diagnosed", error_str);
245+
246+
pfree(error_str);
247+
pfree(lex);
248+
destroyPQExpBuffer(testname);
249+
destroyPQExpBuffer(raw_buf);
250+
}
251+
252+
167253
static bool
168254
escape_literal(PGconn *conn, PQExpBuffer target,
169255
const char *unescaped, size_t unescaped_len,
@@ -454,8 +540,18 @@ static pe_test_vector pe_test_vectors[] =
454540
* Testcases that are not null terminated for the specified input length.
455541
* That's interesting to verify that escape functions don't read beyond
456542
* the intended input length.
543+
*
544+
* One interesting special case is GB18030, which has the odd behaviour
545+
* needing to read beyond the first byte to determine the length of a
546+
* multi-byte character.
457547
*/
458548
TV_LEN("gbk", "\x80", 1),
549+
TV_LEN("GB18030", "\x80", 1),
550+
TV_LEN("GB18030", "\x80\0", 2),
551+
TV_LEN("GB18030", "\x80\x30", 2),
552+
TV_LEN("GB18030", "\x80\x30\0", 3),
553+
TV_LEN("GB18030", "\x80\x30\x30", 3),
554+
TV_LEN("GB18030", "\x80\x30\x30\0", 4),
459555
TV_LEN("UTF-8", "\xC3\xb6 ", 1),
460556
TV_LEN("UTF-8", "\xC3\xb6 ", 2),
461557
};
@@ -864,6 +960,9 @@ main(int argc, char *argv[])
864960
exit(1);
865961
}
866962

963+
test_gb18030_page_multiple(&tc);
964+
test_gb18030_json(&tc);
965+
867966
for (int i = 0; i < lengthof(pe_test_vectors); i++)
868967
{
869968
test_one_vector(&tc, &pe_test_vectors[i]);

‎src/test/regress/expected/conversion.out

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -508,10 +508,13 @@ insert into gb18030_inputs values
508508
('\x666f6f84309c38', 'valid, translates to UTF-8 by mapping function'),
509509
('\x666f6f84309c', 'incomplete char '),
510510
('\x666f6f84309c0a', 'incomplete char, followed by newline '),
511+
('\x666f6f84', 'incomplete char at end'),
511512
('\x666f6f84309c3800', 'invalid, NUL byte'),
512513
('\x666f6f84309c0038', 'invalid, NUL byte');
513-
-- Test GB18030 verification
514-
select description, inbytes, (test_conv(inbytes, 'gb18030', 'gb18030')).* from gb18030_inputs;
514+
-- Test GB18030 verification. Round-trip through text so the backing of the
515+
-- bytea values is palloc, not shared_buffers. This lets Valgrind detect
516+
-- reads past the end.
517+
select description, inbytes, (test_conv(inbytes::text::bytea, 'gb18030', 'gb18030')).* from gb18030_inputs;
515518
description | inbytes | result | errorat | error
516519
------------------------------------------------+--------------------+------------------+--------------+-------------------------------------------------------------------
517520
valid, pure ASCII | \x666f6f | \x666f6f | |
@@ -520,9 +523,10 @@ select description, inbytes, (test_conv(inbytes, 'gb18030', 'gb18030')).* from g
520523
valid, translates to UTF-8 by mapping function | \x666f6f84309c38 | \x666f6f84309c38 | |
521524
incomplete char | \x666f6f84309c | \x666f6f | \x84309c | invalid byte sequence for encoding "GB18030": 0x84 0x30 0x9c
522525
incomplete char, followed by newline | \x666f6f84309c0a | \x666f6f | \x84309c0a | invalid byte sequence for encoding "GB18030": 0x84 0x30 0x9c 0x0a
526+
incomplete char at end | \x666f6f84 | \x666f6f | \x84 | invalid byte sequence for encoding "GB18030": 0x84
523527
invalid, NUL byte | \x666f6f84309c3800 | \x666f6f84309c38 | \x00 | invalid byte sequence for encoding "GB18030": 0x00
524528
invalid, NUL byte | \x666f6f84309c0038 | \x666f6f | \x84309c0038 | invalid byte sequence for encoding "GB18030": 0x84 0x30 0x9c 0x00
525-
(8 rows)
529+
(9 rows)
526530

527531
-- Test conversions from GB18030
528532
select description, inbytes, (test_conv(inbytes, 'gb18030', 'utf8')).* from gb18030_inputs;
@@ -534,9 +538,10 @@ select description, inbytes, (test_conv(inbytes, 'gb18030', 'utf8')).* from gb18
534538
valid, translates to UTF-8 by mapping function | \x666f6f84309c38 | \x666f6fefa8aa | |
535539
incomplete char | \x666f6f84309c | \x666f6f | \x84309c | invalid byte sequence for encoding "GB18030": 0x84 0x30 0x9c
536540
incomplete char, followed by newline | \x666f6f84309c0a | \x666f6f | \x84309c0a | invalid byte sequence for encoding "GB18030": 0x84 0x30 0x9c 0x0a
541+
incomplete char at end | \x666f6f84 | \x666f6f | \x84 | invalid byte sequence for encoding "GB18030": 0x84
537542
invalid, NUL byte | \x666f6f84309c3800 | \x666f6fefa8aa | \x00 | invalid byte sequence for encoding "GB18030": 0x00
538543
invalid, NUL byte | \x666f6f84309c0038 | \x666f6f | \x84309c0038 | invalid byte sequence for encoding "GB18030": 0x84 0x30 0x9c 0x00
539-
(8 rows)
544+
(9 rows)
540545

541546
--
542547
-- ISO-8859-5

‎src/test/regress/sql/conversion.sql

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -300,11 +300,14 @@ insert into gb18030_inputs values
300300
('\x666f6f84309c38', 'valid, translates to UTF-8 by mapping function'),
301301
('\x666f6f84309c', 'incomplete char '),
302302
('\x666f6f84309c0a', 'incomplete char, followed by newline '),
303+
('\x666f6f84', 'incomplete char at end'),
303304
('\x666f6f84309c3800', 'invalid, NUL byte'),
304305
('\x666f6f84309c0038', 'invalid, NUL byte');
305306

306-
-- Test GB18030 verification
307-
select description, inbytes, (test_conv(inbytes, 'gb18030', 'gb18030')).* from gb18030_inputs;
307+
-- Test GB18030 verification. Round-trip through text so the backing of the
308+
-- bytea values is palloc, not shared_buffers. This lets Valgrind detect
309+
-- reads past the end.
310+
select description, inbytes, (test_conv(inbytes::text::bytea, 'gb18030', 'gb18030')).* from gb18030_inputs;
308311
-- Test conversions from GB18030
309312
select description, inbytes, (test_conv(inbytes, 'gb18030', 'utf8')).* from gb18030_inputs;
310313

0 commit comments

Comments
 (0)