Fix resource leak pointed out by Coverity.

tatsuo-ishii · tatsuo-ishii · commit 458e8bc653ab · 2014-12-30T20:27:26.000+09:00
diff --git a/contrib/pgbench/pgbench.c b/contrib/pgbench/pgbench.c
@@ -1929,6 +1929,7 @@ parseQuery(Command *cmd, const char *raw_sql)
 		if (cmd->argc >= MAX_ARGS)
 		{
 			fprintf(stderr, "statement has too many arguments (maximum is %d): %s\n", MAX_ARGS - 1, raw_sql);
+			pg_free(name);
 			return false;
 		}
 
@@ -2169,6 +2170,7 @@ process_file(char *filename)
 	else if ((fd = fopen(filename, "r")) == NULL)
 	{
 		fprintf(stderr, "%s: %s\n", filename, strerror(errno));
+		pg_free(my_commands);
 		return false;
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -1929,6 +1929,7 @@ parseQuery(Command cmd, const char raw_sql)`
`1929`	`1929`	`if (cmd->argc >= MAX_ARGS)`
`1930`	`1930`	`{`
`1931`	`1931`	`fprintf(stderr, "statement has too many arguments (maximum is %d): %s\n", MAX_ARGS - 1, raw_sql);`
	`1932`	`+ pg_free(name);`
`1932`	`1933`	`return false;`
`1933`	`1934`	`}`
`1934`	`1935`
`@@ -2169,6 +2170,7 @@ process_file(char *filename)`
`2169`	`2170`	`else if ((fd = fopen(filename, "r")) == NULL)`
`2170`	`2171`	`{`
`2171`	`2172`	`fprintf(stderr, "%s: %s\n", filename, strerror(errno));`
	`2173`	`+ pg_free(my_commands);`
`2172`	`2174`	`return false;`
`2173`	`2175`	`}`
`2174`	`2176`