Fix planning of SELECT FOR UPDATE on child table with partial index.

tglsfdc · tglsfdc · commit 462bd95705a0 · 2014-12-11T21:02:25.000-05:00
Ordinarily we can omit checking of a WHERE condition that matches a partial
index's condition, when we are using an indexscan on that partial index.
However, in SELECT FOR UPDATE we must include the "redundant" filter
condition in the plan so that it gets checked properly in an EvalPlanQual
recheck.  The planner got this mostly right, but improperly omitted the
filter condition if the index in question was on an inheritance child
table.  In READ COMMITTED mode, this could result in incorrectly returning
just-updated rows that no longer satisfy the filter condition.

The cause of the error is using get_parse_rowmark() when get_plan_rowmark()
is what should be used during planning.  In 9.3 and up, also fix the same
mistake in contrib/postgres_fdw.  It's currently harmless there (for lack
of inheritance support) but wrong is wrong, and the incorrect code might
get copied to someplace where it's more significant.

Report and fix by Kyotaro Horiguchi.  Back-patch to all supported branches.
diff --git a/contrib/postgres_fdw/postgres_fdw.c b/contrib/postgres_fdw/postgres_fdw.c
@@ -822,7 +822,7 @@ postgresGetForeignPlan(PlannerInfo *root,
 	}
 	else
 	{
-		RowMarkClause *rc = get_parse_rowmark(root->parse, baserel->relid);
+		PlanRowMark *rc = get_plan_rowmark(root->rowMarks, baserel->relid);
 
 		if (rc)
 		{
@@ -835,15 +835,18 @@ postgresGetForeignPlan(PlannerInfo *root,
 			 * complete information about, and (b) it wouldn't work anyway on
 			 * older remote servers.  Likewise, we don't worry about NOWAIT.
 			 */
-			switch (rc->strength)
+			switch (rc->markType)
 			{
-				case LCS_FORKEYSHARE:
-				case LCS_FORSHARE:
+				case ROW_MARK_EXCLUSIVE:
+				case ROW_MARK_NOKEYEXCLUSIVE:
+					appendStringInfoString(&sql, " FOR UPDATE");
+					break;
+				case ROW_MARK_SHARE:
+				case ROW_MARK_KEYSHARE:
 					appendStringInfoString(&sql, " FOR SHARE");
 					break;
-				case LCS_FORNOKEYUPDATE:
-				case LCS_FORUPDATE:
-					appendStringInfoString(&sql, " FOR UPDATE");
+				default:
+					/* nothing needed */
 					break;
 			}
 		}
diff --git a/src/backend/optimizer/plan/createplan.c b/src/backend/optimizer/plan/createplan.c
@@ -34,6 +34,7 @@
 #include "optimizer/planmain.h"
 #include "optimizer/planner.h"
 #include "optimizer/predtest.h"
+#include "optimizer/prep.h"
 #include "optimizer/restrictinfo.h"
 #include "optimizer/subselect.h"
 #include "optimizer/tlist.h"
@@ -1231,7 +1232,7 @@ create_indexscan_plan(PlannerInfo *root,
 			if (best_path->indexinfo->indpred)
 			{
 				if (baserelid != root->parse->resultRelation &&
-					get_parse_rowmark(root->parse, baserelid) == NULL)
+					get_plan_rowmark(root->rowMarks, baserelid) == NULL)
 					if (predicate_implied_by(clausel,
 											 best_path->indexinfo->indpred))
 						continue;		/* implied by index predicate */

Original file line number	Diff line number	Diff line change
`@@ -822,7 +822,7 @@ postgresGetForeignPlan(PlannerInfo *root,`
`822`	`822`	`}`
`823`	`823`	`else`
`824`	`824`	`{`
`825`		`- RowMarkClause *rc = get_parse_rowmark(root->parse, baserel->relid);`
	`825`	`+ PlanRowMark *rc = get_plan_rowmark(root->rowMarks, baserel->relid);`
`826`	`826`
`827`	`827`	`if (rc)`
`828`	`828`	`{`
`@@ -835,15 +835,18 @@ postgresGetForeignPlan(PlannerInfo *root,`
`835`	`835`	`* complete information about, and (b) it wouldn't work anyway on`
`836`	`836`	`* older remote servers. Likewise, we don't worry about NOWAIT.`
`837`	`837`	`*/`
`838`		`- switch (rc->strength)`
	`838`	`+ switch (rc->markType)`
`839`	`839`	`{`
`840`		`- case LCS_FORKEYSHARE:`
`841`		`- case LCS_FORSHARE:`
	`840`	`+ case ROW_MARK_EXCLUSIVE:`
	`841`	`+ case ROW_MARK_NOKEYEXCLUSIVE:`
	`842`	`+ appendStringInfoString(&sql, " FOR UPDATE");`
	`843`	`+ break;`
	`844`	`+ case ROW_MARK_SHARE:`
	`845`	`+ case ROW_MARK_KEYSHARE:`
`842`	`846`	`appendStringInfoString(&sql, " FOR SHARE");`
`843`	`847`	`break;`
`844`		`- case LCS_FORNOKEYUPDATE:`
`845`		`- case LCS_FORUPDATE:`
`846`		`- appendStringInfoString(&sql, " FOR UPDATE");`
	`848`	`+ default:`
	`849`	`+ /* nothing needed */`
`847`	`850`	`break;`
`848`	`851`	`}`
`849`	`852`	`}`