Print wal_log_hints in the rm_desc routing of a parameter-change record.

hlinnaka · hlinnaka · commit 463dde8def8b · 2014-12-05T12:05:10.000+02:00
It was an oversight in the original commit.

Also note in the sample config file that changing wal_log_hints requires a
restart.

Michael Paquier. Backpatch to 9.4, where wal_log_hints was added.
diff --git a/src/backend/access/rmgrdesc/xlogdesc.c b/src/backend/access/rmgrdesc/xlogdesc.c
@@ -117,12 +117,15 @@ xlog_desc(StringInfo buf, uint8 xl_info, char *rec)
 			}
 		}
 
-		appendStringInfo(buf, "parameter change: max_connections=%d max_worker_processes=%d max_prepared_xacts=%d max_locks_per_xact=%d wal_level=%s",
+		appendStringInfo(buf, "parameter change: max_connections=%d max_worker_processes=%d "
+						 "max_prepared_xacts=%d max_locks_per_xact=%d "
+						 "wal_level=%s wal_log_hints=%s",
 						 xlrec.MaxConnections,
 						 xlrec.max_worker_processes,
 						 xlrec.max_prepared_xacts,
 						 xlrec.max_locks_per_xact,
-						 wal_level_str);
+						 wal_level_str,
+						 xlrec.wal_log_hints ? "on" : "off");
 	}
 	else if (info == XLOG_FPW_CHANGE)
 	{
diff --git a/src/backend/utils/misc/postgresql.conf.sample b/src/backend/utils/misc/postgresql.conf.sample
@@ -186,6 +186,7 @@
 					#   open_sync
 #full_page_writes = on			# recover from partial page writes
 #wal_log_hints = off			# also do full page writes of non-critical updates
+					# (change requires restart)
 #wal_buffers = -1			# min 32kB, -1 sets based on shared_buffers
 					# (change requires restart)
 #wal_writer_delay = 200ms		# 1-10000 milliseconds

Original file line number	Diff line number	Diff line change
`@@ -117,12 +117,15 @@ xlog_desc(StringInfo buf, uint8 xl_info, char *rec)`
`117`	`117`	`}`
`118`	`118`	`}`
`119`	`119`
`120`		`- appendStringInfo(buf, "parameter change: max_connections=%d max_worker_processes=%d max_prepared_xacts=%d max_locks_per_xact=%d wal_level=%s",`
	`120`	`+ appendStringInfo(buf, "parameter change: max_connections=%d max_worker_processes=%d "`
	`121`	`+ "max_prepared_xacts=%d max_locks_per_xact=%d "`
	`122`	`+ "wal_level=%s wal_log_hints=%s",`
`121`	`123`	`xlrec.MaxConnections,`
`122`	`124`	`xlrec.max_worker_processes,`
`123`	`125`	`xlrec.max_prepared_xacts,`
`124`	`126`	`xlrec.max_locks_per_xact,`
`125`		`- wal_level_str);`
	`127`	`+ wal_level_str,`
	`128`	`+ xlrec.wal_log_hints ? "on" : "off");`
`126`	`129`	`}`
`127`	`130`	`else if (info == XLOG_FPW_CHANGE)`
`128`	`131`	`{`