oauth: Remove timeout from t/002_client when not needed

danielgustafsson · danielgustafsson · commit 46c4c7cbc6d5 · 2025-04-03T20:41:09.000+02:00
The connect_timeout=1 setting for the --hang-forever test was left in
place and used by later tests, causing unexpected timeouts on slower
buildfarm animals. Remove it when no longer needed.

Per buildfarm member skink, reported by Andres on Discord.

Author: Jacob Champion &lt;jacob.champion@enterprisedb.com&gt;
Reported-by: Andres Freund &lt;andres@anarazel.de&gt;
diff --git a/src/test/modules/oauth_validator/t/002_client.pl b/src/test/modules/oauth_validator/t/002_client.pl
@@ -122,6 +122,9 @@ sub test
 	flags => ["--hang-forever"],
 	expected_stderr => qr/failed: timeout expired/);
 
+# Remove the timeout for later tests.
+$common_connstr = "$base_connstr oauth_issuer=$issuer oauth_client_id=myID";
+
 # Test various misbehaviors of the client hook.
 my @cases = (
 	{

Original file line number	Diff line number	Diff line change
`@@ -122,6 +122,9 @@ sub test`
`122`	`122`	`flags => ["--hang-forever"],`
`123`	`123`	`expected_stderr => qr/failed: timeout expired/);`
`124`	`124`
	`125`	`+# Remove the timeout for later tests.`
	`126`	`+$common_connstr = "$base_connstr oauth_issuer=$issuer oauth_client_id=myID";`
	`127`	`+`
`125`	`128`	`# Test various misbehaviors of the client hook.`
`126`	`129`	`my @cases = (`
`127`	`130`	`{`