Skip to content

Commit 47ce95a

Browse files
committed
Now that much of walreceiver has been pulled back into the postgres
binary, revert PGDLLIMPORT decoration of global variables. I'm not sure if there's any real harm from unnecessary PGDLLIMPORTs, but these are all internal variables that external modules really shouldn't be messing with. ThisTimeLineID still needs PGDLLIMPORT.
1 parent b3a1ef5 commit 47ce95a

File tree

3 files changed

+7
-7
lines changed

3 files changed

+7
-7
lines changed

src/include/libpq/pqsignal.h

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* Portions Copyright (c) 1996-2010, PostgreSQL Global Development Group
88
* Portions Copyright (c) 1994, Regents of the University of California
99
*
10-
* $PostgreSQL: pgsql/src/include/libpq/pqsignal.h,v 1.39 2010/01/16 05:52:29 tgl Exp $
10+
* $PostgreSQL: pgsql/src/include/libpq/pqsignal.h,v 1.40 2010/01/20 18:54:27 heikki Exp $
1111
*
1212
* NOTES
1313
* This shouldn't be in libpq, but the monitor and some other
@@ -21,13 +21,13 @@
2121
#include <signal.h>
2222

2323
#ifdef HAVE_SIGPROCMASK
24-
extern PGDLLIMPORT sigset_t UnBlockSig,
24+
extern sigset_t UnBlockSig,
2525
BlockSig,
2626
StartupBlockSig;
2727

2828
#define PG_SETMASK(mask) sigprocmask(SIG_SETMASK, mask, NULL)
2929
#else /* not HAVE_SIGPROCMASK */
30-
extern PGDLLIMPORT int UnBlockSig,
30+
extern int UnBlockSig,
3131
BlockSig,
3232
StartupBlockSig;
3333

src/include/replication/walreceiver.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
*
66
* Portions Copyright (c) 2010-2010, PostgreSQL Global Development Group
77
*
8-
* $PostgreSQL: pgsql/src/include/replication/walreceiver.h,v 1.3 2010/01/20 09:16:24 heikki Exp $
8+
* $PostgreSQL: pgsql/src/include/replication/walreceiver.h,v 1.4 2010/01/20 18:54:27 heikki Exp $
99
*
1010
*-------------------------------------------------------------------------
1111
*/
@@ -59,7 +59,7 @@ typedef struct
5959
slock_t mutex; /* locks shared variables shown above */
6060
} WalRcvData;
6161

62-
extern PGDLLIMPORT WalRcvData *WalRcv;
62+
extern WalRcvData *WalRcv;
6363

6464
/* libpqwalreceiver hooks */
6565
typedef bool (*walrcv_connect_type) (char *conninfo, XLogRecPtr startpoint);

src/include/storage/ipc.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
* Portions Copyright (c) 1996-2010, PostgreSQL Global Development Group
1212
* Portions Copyright (c) 1994, Regents of the University of California
1313
*
14-
* $PostgreSQL: pgsql/src/include/storage/ipc.h,v 1.80 2010/01/16 00:04:41 tgl Exp $
14+
* $PostgreSQL: pgsql/src/include/storage/ipc.h,v 1.81 2010/01/20 18:54:27 heikki Exp $
1515
*
1616
*-------------------------------------------------------------------------
1717
*/
@@ -62,7 +62,7 @@ typedef void (*shmem_startup_hook_type) (void);
6262

6363

6464
/* ipc.c */
65-
extern PGDLLIMPORT bool proc_exit_inprogress;
65+
extern bool proc_exit_inprogress;
6666

6767
extern void proc_exit(int code);
6868
extern void shmem_exit(int code);

0 commit comments

Comments
 (0)