Skip to content

Commit 4a235ef

Browse files
committed
Make configure check for minimum required version of IPC::Run.
Per the discussion around 3eb1f4d, let's have configure verify that the available IPC::Run version is at least 0.79, the agreed-on minimum. It seems unlikely that this could bite anybody anymore, but it's useful as documentation. (Based on that, there's little need to back-patch.) For consistency, also supply a minimum version for the other Perl module we have an explicit check for, Time::HiRes. I used the version that ships with Perl 5.8.3. Discussion: https://postgr.es/m/E1mYY6Z-0006OL-QN@gemulon.postgresql.org
1 parent 39ae0ef commit 4a235ef

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

configure

+3-1
Original file line numberDiff line numberDiff line change
@@ -19255,6 +19255,8 @@ if test "$enable_tap_tests" = yes; then
1925519255
if test -z "$PROVE"; then
1925619256
# Test::More and Time::HiRes are supposed to be part of core Perl,
1925719257
# but some distros omit them in a minimal installation.
19258+
# The required minimum versions are all quite ancient now, but specify
19259+
# them anyway for documentation's sake.
1925819260

1925919261

1926019262

@@ -19308,7 +19310,7 @@ fi
1930819310

1930919311
if test "x$PERL" != x; then
1931019312
ax_perl_modules_failed=0
19311-
for ax_perl_module in 'IPC::Run' 'Test::More 0.87' 'Time::HiRes' ; do
19313+
for ax_perl_module in 'IPC::Run 0.79' 'Test::More 0.87' 'Time::HiRes 1.52' ; do
1931219314
{ $as_echo "$as_me:${as_lineno-$LINENO}: checking for perl module $ax_perl_module" >&5
1931319315
$as_echo_n "checking for perl module $ax_perl_module... " >&6; }
1931419316

configure.ac

+3-1
Original file line numberDiff line numberDiff line change
@@ -2348,7 +2348,9 @@ if test "$enable_tap_tests" = yes; then
23482348
if test -z "$PROVE"; then
23492349
# Test::More and Time::HiRes are supposed to be part of core Perl,
23502350
# but some distros omit them in a minimal installation.
2351-
AX_PROG_PERL_MODULES([IPC::Run Test::More=0.87 Time::HiRes], ,
2351+
# The required minimum versions are all quite ancient now, but specify
2352+
# them anyway for documentation's sake.
2353+
AX_PROG_PERL_MODULES([IPC::Run=0.79 Test::More=0.87 Time::HiRes=1.52], ,
23522354
[AC_MSG_ERROR([Additional Perl modules are required to run TAP tests])])
23532355
fi
23542356
# Now make sure we know where prove is

0 commit comments

Comments
 (0)