Remove GLOBALTABLESPACE_OID assert for locked buffers.

nmisch · nmisch · commit 4a4ee0c2c1e5 · 2025-05-10T07:36:27.000-07:00
Commit f4ece89 added the assertion in an attempt to catch some defects even after VACUUM FULL or REINDEX. However, IsCatalogTextUniqueIndexOid(tag.relNumber) always returns false after a relfilenode change, provoking unintended assertion failures. Reported-by: Adam Guo <adamguo@amazon.com> Reviewed-by: Masahiko Sawada <sawada.mshk@gmail.com> Bug: #18912 Discussion: https://postgr.es/m/18912-a41c9bd0e0ad19b1@postgresql.org
diff --git a/src/backend/storage/buffer/bufmgr.c b/src/backend/storage/buffer/bufmgr.c
@@ -4161,8 +4161,6 @@ AssertNotCatalogBufferLock(LWLock *lock, LWLockMode mode,
 		return;
 
 	Assert(!IsCatalogRelationOid(relid));
-	/* Shared rels are always catalogs: detect even after VACUUM FULL. */
-	Assert(tag.spcOid != GLOBALTABLESPACE_OID);
 }
 #endif
 

Original file line number	Diff line number	Diff line change
`@@ -4161,8 +4161,6 @@ AssertNotCatalogBufferLock(LWLock *lock, LWLockMode mode,`
`4161`	`4161`	`return;`
`4162`	`4162`
`4163`	`4163`	`Assert(!IsCatalogRelationOid(relid));`
`4164`		`- /* Shared rels are always catalogs: detect even after VACUUM FULL. */`
`4165`		`- Assert(tag.spcOid != GLOBALTABLESPACE_OID);`
`4166`	`4164`	`}`
`4167`	`4165`	`#endif`
`4168`	`4166`