Portability fix: isdigit() must be passed an unsigned char.

tglsfdc · tglsfdc · commit 4aad2cb7707d · 2025-04-17T16:33:21.000-04:00
Oversight in commit 40b9c27, per buildfarm member mamba.
diff --git a/src/bin/pg_dump/pg_restore.c b/src/bin/pg_dump/pg_restore.c
@@ -1073,7 +1073,7 @@ get_dbname_oid_list_from_mfile(const char *dumpdirpath, SimplePtrList *dbname_oi
 		char	   *p = linebuf.data;
 
 		/* Extract dboid. */
-		while (isdigit(*p))
+		while (isdigit((unsigned char) *p))
 			p++;
 		if (p > linebuf.data && *p == ' ')
 		{

Original file line number	Diff line number	Diff line change
`@@ -1073,7 +1073,7 @@ get_dbname_oid_list_from_mfile(const char dumpdirpath, SimplePtrList dbname_oi`
`1073`	`1073`	`char *p = linebuf.data;`
`1074`	`1074`
`1075`	`1075`	`/* Extract dboid. */`
`1076`		`- while (isdigit(*p))`
	`1076`	`+ while (isdigit((unsigned char) *p))`
`1077`	`1077`	`p++;`
`1078`	`1078`	`if (p > linebuf.data && *p == ' ')`
`1079`	`1079`	`{`