Fix our mapping of Windows timezones for Central America.

tglsfdc · tglsfdc · commit 4c5d837e69cf · 2011-09-23T22:07:52.000-04:00
We were mapping "Central America Standard Time" to "CST6CDT", which seems
entirely wrong, because according to the Olson timezone database noplace
in Central America observes daylight savings time on any regular basis ---
and certainly not according to the USA DST rules that are implied by
"CST6CDT".  (Mexico is an exception, but they can be disregarded since
they have a separate timezone name in Windows.)  So, map this zone name to
plain "CST6", which will provide a fixed UTC offset.

As written, this patch will also result in mapping "Central America
Daylight Time" to CST6.  I considered hacking things so that would still
map to CST6CDT, but it seems it would confuse win32tzlist.pl to put those
two names in separate entries.  Since there's little evidence that any
such zone name is used in the wild, much less that CST6CDT would be a good
match for it, I'm not too worried about what we do with it.

Per complaint from Pratik Chirania.
diff --git a/src/bin/initdb/findtimezone.c b/src/bin/initdb/findtimezone.c
@@ -658,9 +658,10 @@ static const struct
 		"Cen. Australia Standard Time", "Cen. Australia Daylight Time",
 		"Australia/Adelaide"
 	},							/* (GMT+09:30) Adelaide */
+	/* Central America (other than Mexico) generally does not observe DST */
 	{
 		"Central America Standard Time", "Central America Daylight Time",
-		"CST6CDT"
+		"CST6"
 	},							/* (GMT-06:00) Central America */
 	{
 		"Central Asia Standard Time", "Central Asia Daylight Time",

Original file line number	Diff line number	Diff line change
`@@ -658,9 +658,10 @@ static const struct`
`658`	`658`	`"Cen. Australia Standard Time", "Cen. Australia Daylight Time",`
`659`	`659`	`"Australia/Adelaide"`
`660`	`660`	`}, /* (GMT+09:30) Adelaide */`
	`661`	`+ /* Central America (other than Mexico) generally does not observe DST */`
`661`	`662`	`{`
`662`	`663`	`"Central America Standard Time", "Central America Daylight Time",`
`663`		`- "CST6CDT"`
	`664`	`+ "CST6"`
`664`	`665`	`}, /* (GMT-06:00) Central America */`
`665`	`666`	`{`
`666`	`667`	`"Central Asia Standard Time", "Central Asia Daylight Time",`