Fix double-free bug of WAL streaming buffer in pg_receivexlog.

MasaoFujii · MasaoFujii · commit 4ccac92d08f2 · 2014-07-04T19:48:38.000+09:00
This bug was introduced while refactoring in commit 74cbe96.
diff --git a/src/bin/pg_basebackup/receivelog.c b/src/bin/pg_basebackup/receivelog.c
@@ -1079,12 +1079,11 @@ CopyStreamPoll(PGconn *conn, long timeout_ms)
 static int
 CopyStreamReceive(PGconn *conn, long timeout, char **buffer)
 {
-	static char	   *copybuf = NULL;
+	char	   *copybuf = NULL;
 	int			rawlen;
 
-	if (copybuf != NULL)
-		PQfreemem(copybuf);
-	copybuf = NULL;
+	if (*buffer != NULL)
+		PQfreemem(*buffer);
 	*buffer = NULL;
 
 	/* Try to receive a CopyData message */
