Fix compiler warning in rangetypes_spgist.c.

tglsfdc · tglsfdc · commit 52f63bd91618 · 2017-11-18T16:46:29.000-05:00
On gcc 7.2.0, comparing pointer to (Datum) 0 produces a warning. Treat it as a simple pointer to avoid that; this is more consistent with comparable code elsewhere, anyway. Tomas Vondra Discussion: https://postgr.es/m/99410021-61ef-9a9a-9bc8-f733ece637ee@2ndquadrant.com
diff --git a/src/backend/utils/adt/rangetypes_spgist.c b/src/backend/utils/adt/rangetypes_spgist.c
@@ -556,7 +556,7 @@ spg_range_quad_inner_consistent(PG_FUNCTION_ARGS)
 					 * for lower or upper bounds to be adjacent. Deserialize
 					 * previous centroid range if present for checking this.
 					 */
-					if (in->traversalValue != (Datum) 0)
+					if (in->traversalValue)
 					{
 						prevCentroid = DatumGetRangeTypeP(in->traversalValue);
 						range_deserialize(typcache, prevCentroid,

Original file line number	Diff line number	Diff line change
`@@ -556,7 +556,7 @@ spg_range_quad_inner_consistent(PG_FUNCTION_ARGS)`
`556`	`556`	`* for lower or upper bounds to be adjacent. Deserialize`
`557`	`557`	`* previous centroid range if present for checking this.`
`558`	`558`	`*/`
`559`		`- if (in->traversalValue != (Datum) 0)`
	`559`	`+ if (in->traversalValue)`
`560`	`560`	`{`
`561`	`561`	`prevCentroid = DatumGetRangeTypeP(in->traversalValue);`
`562`	`562`	`range_deserialize(typcache, prevCentroid,`