Remove deprecated syntax from CREATE/DROP LANGUAGE

petere · petere · commit 5333e014ab94 · 2020-06-11T10:26:12.000+02:00
Remove the option to specify the language name as a single-quoted string. This has been obsolete since ee8ed85. Removing it allows better grammar refactoring. The syntax of the CREATE FUNCTION LANGUAGE clause is not changed. Discussion: https://www.postgresql.org/message-id/flat/163c00a5-f634-ca52-fc7c-0e53deda8735%402ndquadrant.com
diff --git a/doc/src/sgml/ref/create_language.sgml b/doc/src/sgml/ref/create_language.sgml
@@ -110,11 +110,6 @@ CREATE [ OR REPLACE ] [ TRUSTED ] [ PROCEDURAL ] LANGUAGE <replaceable class="pa
        The name of the new procedural language.
        The name must be unique among the languages in the database.
       </para>
-
-      <para>
-       For backward compatibility, the name can be enclosed by single
-       quotes.
-      </para>
      </listitem>
     </varlistentry>
 
diff --git a/doc/src/sgml/ref/drop_language.sgml b/doc/src/sgml/ref/drop_language.sgml
@@ -63,8 +63,7 @@ DROP [ PROCEDURAL ] LANGUAGE [ IF EXISTS ] <replaceable class="parameter">name</
     <term><replaceable class="parameter">name</replaceable></term>
     <listitem>
      <para>
-      The name of an existing procedural language.  For backward
-      compatibility, the name can be enclosed by single quotes.
+      The name of an existing procedural language.
      </para>
     </listitem>
    </varlistentry>
diff --git a/src/backend/parser/gram.y b/src/backend/parser/gram.y
@@ -4346,7 +4346,7 @@ NumericOnly_list:	NumericOnly						{ $$ = list_make1($1); }
  *****************************************************************************/
 
 CreatePLangStmt:
-			CREATE opt_or_replace opt_trusted opt_procedural LANGUAGE NonReservedWord_or_Sconst
+			CREATE opt_or_replace opt_trusted opt_procedural LANGUAGE name
 			{
 				/*
 				 * We now interpret parameterless CREATE LANGUAGE as
@@ -4361,7 +4361,7 @@ CreatePLangStmt:
 				n->options = NIL;
 				$$ = (Node *)n;
 			}
-			| CREATE opt_or_replace opt_trusted opt_procedural LANGUAGE NonReservedWord_or_Sconst
+			| CREATE opt_or_replace opt_trusted opt_procedural LANGUAGE name
 			  HANDLER handler_name opt_inline_handler opt_validator
 			{
 				CreatePLangStmt *n = makeNode(CreatePLangStmt);
@@ -4405,7 +4405,7 @@ opt_validator:
 		;
 
 DropPLangStmt:
-			DROP opt_procedural LANGUAGE NonReservedWord_or_Sconst opt_drop_behavior
+			DROP opt_procedural LANGUAGE name opt_drop_behavior
 				{
 					DropStmt *n = makeNode(DropStmt);
 					n->removeType = OBJECT_LANGUAGE;
@@ -4415,7 +4415,7 @@ DropPLangStmt:
 					n->concurrent = false;
 					$$ = (Node *)n;
 				}
-			| DROP opt_procedural LANGUAGE IF_P EXISTS NonReservedWord_or_Sconst opt_drop_behavior
+			| DROP opt_procedural LANGUAGE IF_P EXISTS name opt_drop_behavior
 				{
 					DropStmt *n = makeNode(DropStmt);
 					n->removeType = OBJECT_LANGUAGE;

Original file line number	Diff line number	Diff line change
`@@ -4346,7 +4346,7 @@ NumericOnly_list: NumericOnly { $$ = list_make1($1); }`
`4346`	`4346`	`*****************************************************************************/`
`4347`	`4347`
`4348`	`4348`	`CreatePLangStmt:`
`4349`		`- CREATE opt_or_replace opt_trusted opt_procedural LANGUAGE NonReservedWord_or_Sconst`
	`4349`	`+ CREATE opt_or_replace opt_trusted opt_procedural LANGUAGE name`
`4350`	`4350`	`{`
`4351`	`4351`	`/*`
`4352`	`4352`	`* We now interpret parameterless CREATE LANGUAGE as`
`@@ -4361,7 +4361,7 @@ CreatePLangStmt:`
`4361`	`4361`	`n->options = NIL;`
`4362`	`4362`	`$$ = (Node *)n;`
`4363`	`4363`	`}`
`4364`		`- \| CREATE opt_or_replace opt_trusted opt_procedural LANGUAGE NonReservedWord_or_Sconst`
	`4364`	`+ \| CREATE opt_or_replace opt_trusted opt_procedural LANGUAGE name`
`4365`	`4365`	`HANDLER handler_name opt_inline_handler opt_validator`
`4366`	`4366`	`{`
`4367`	`4367`	`CreatePLangStmt *n = makeNode(CreatePLangStmt);`
`@@ -4405,7 +4405,7 @@ opt_validator:`
`4405`	`4405`	`;`
`4406`	`4406`
`4407`	`4407`	`DropPLangStmt:`
`4408`		`- DROP opt_procedural LANGUAGE NonReservedWord_or_Sconst opt_drop_behavior`
	`4408`	`+ DROP opt_procedural LANGUAGE name opt_drop_behavior`
`4409`	`4409`	`{`
`4410`	`4410`	`DropStmt *n = makeNode(DropStmt);`
`4411`	`4411`	`n->removeType = OBJECT_LANGUAGE;`
`@@ -4415,7 +4415,7 @@ DropPLangStmt:`
`4415`	`4415`	`n->concurrent = false;`
`4416`	`4416`	`$$ = (Node *)n;`
`4417`	`4417`	`}`
`4418`		`- \| DROP opt_procedural LANGUAGE IF_P EXISTS NonReservedWord_or_Sconst opt_drop_behavior`
	`4418`	`+ \| DROP opt_procedural LANGUAGE IF_P EXISTS name opt_drop_behavior`
`4419`	`4419`	`{`
`4420`	`4420`	`DropStmt *n = makeNode(DropStmt);`
`4421`	`4421`	`n->removeType = OBJECT_LANGUAGE;`