Skip to content

Commit 56c6703

Browse files
author
Etsuro Fujita
committed
postgres_fdw: Improve comment about handling of asynchronous requests.
We updated this comment in back branches (see commit f6f61a4 et al); let's do so in HEAD as well for consistency. Discussion: https://postgr.es/m/CAPmGK142V1kqDfjo2H%2Bb54JTn2woVBrisFq%2B%3D9jwXwxr0VvbgA%40mail.gmail.com
1 parent 8f136af commit 56c6703

File tree

1 file changed

+10
-8
lines changed

1 file changed

+10
-8
lines changed

contrib/postgres_fdw/postgres_fdw.c

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -7270,14 +7270,16 @@ postgresForeignAsyncConfigureWait(AsyncRequest *areq)
72707270
{
72717271
/*
72727272
* This is the case when the in-process request was made by another
7273-
* Append. Note that it might be useless to process the request,
7274-
* because the query might not need tuples from that Append anymore.
7275-
* If there are any child subplans of the same parent that are ready
7276-
* for new requests, skip the given request. Likewise, if there are
7277-
* any configured events other than the postmaster death event, skip
7278-
* it. Otherwise, process the in-process request, then begin a fetch
7279-
* to configure the event below, because we might otherwise end up
7280-
* with no configured events other than the postmaster death event.
7273+
* Append. Note that it might be useless to process the request made
7274+
* by that Append, because the query might not need tuples from that
7275+
* Append anymore; so we avoid processing it to begin a fetch for the
7276+
* given request if possible. If there are any child subplans of the
7277+
* same parent that are ready for new requests, skip the given
7278+
* request. Likewise, if there are any configured events other than
7279+
* the postmaster death event, skip it. Otherwise, process the
7280+
* in-process request, then begin a fetch to configure the event
7281+
* below, because we might otherwise end up with no configured events
7282+
* other than the postmaster death event.
72817283
*/
72827284
if (!bms_is_empty(requestor->as_needrequest))
72837285
return;

0 commit comments

Comments
 (0)