Fix oversight in pg_dump's handling of extension configuration tables.

tglsfdc · tglsfdc · commit 59de132f9a57 · 2012-02-10T15:22:14.000-05:00
If an extension has not been selected to be dumped (perhaps because of
a --schema or --table switch), the contents of its configuration tables
surely should not get dumped either.  Per gripe from
Hubert Depesz Lubaczewski.
diff --git a/src/bin/pg_dump/pg_dump.c b/src/bin/pg_dump/pg_dump.c
@@ -14179,13 +14179,18 @@ getExtensionMembership(Archive *fout, ExtensionInfo extinfo[],
 	 */
 	for (i = 0; i < numExtensions; i++)
 	{
-		char	   *extconfig = extinfo[i].extconfig;
-		char	   *extcondition = extinfo[i].extcondition;
+		ExtensionInfo *curext = &(extinfo[i]);
+		char	   *extconfig = curext->extconfig;
+		char	   *extcondition = curext->extcondition;
 		char	  **extconfigarray = NULL;
 		char	  **extconditionarray = NULL;
 		int			nconfigitems;
 		int			nconditionitems;
 
+		/* Tables of not-to-be-dumped extensions shouldn't be dumped */
+		if (!curext->dobj.dump)
+			continue;
+
 		if (parsePGArray(extconfig, &extconfigarray, &nconfigitems) &&
 		  parsePGArray(extcondition, &extconditionarray, &nconditionitems) &&
 			nconfigitems == nconditionitems)
