Normalize heap_prepare_freeze_tuple argument name.

petergeoghegan · petergeoghegan · commit 5b68f75e1283 · 2022-03-11T19:30:21.000-08:00
We called the argument totally_frozen in its function prototype as well
as in code comments, even though totally_frozen_p was used in the
function definition.  Standardize on totally_frozen.
diff --git a/src/backend/access/heap/heapam.c b/src/backend/access/heap/heapam.c
@@ -6417,7 +6417,7 @@ FreezeMultiXactId(MultiXactId multi, uint16 t_infomask,
  * are older than the specified cutoff XID and cutoff MultiXactId.  If so,
  * setup enough state (in the *frz output argument) to later execute and
  * WAL-log what we would need to do, and return true.  Return false if nothing
- * is to be changed.  In addition, set *totally_frozen_p to true if the tuple
+ * is to be changed.  In addition, set *totally_frozen to true if the tuple
  * will be totally frozen after these operations are performed and false if
  * more freezing will eventually be required.
  *
@@ -6445,7 +6445,7 @@ bool
 heap_prepare_freeze_tuple(HeapTupleHeader tuple,
 						  TransactionId relfrozenxid, TransactionId relminmxid,
 						  TransactionId cutoff_xid, TransactionId cutoff_multi,
-						  xl_heap_freeze_tuple *frz, bool *totally_frozen_p)
+						  xl_heap_freeze_tuple *frz, bool *totally_frozen)
 {
 	bool		changed = false;
 	bool		xmax_already_frozen = false;
@@ -6645,8 +6645,8 @@ heap_prepare_freeze_tuple(HeapTupleHeader tuple,
 		}
 	}
 
-	*totally_frozen_p = (xmin_frozen &&
-						 (freeze_xmax || xmax_already_frozen));
+	*totally_frozen = (xmin_frozen &&
+					   (freeze_xmax || xmax_already_frozen));
 	return changed;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -6417,7 +6417,7 @@ FreezeMultiXactId(MultiXactId multi, uint16 t_infomask,`
`6417`	`6417`	`* are older than the specified cutoff XID and cutoff MultiXactId. If so,`
`6418`	`6418`	`* setup enough state (in the *frz output argument) to later execute and`
`6419`	`6419`	`* WAL-log what we would need to do, and return true. Return false if nothing`
`6420`		`- * is to be changed. In addition, set *totally_frozen_p to true if the tuple`
	`6420`	`+ * is to be changed. In addition, set *totally_frozen to true if the tuple`
`6421`	`6421`	`* will be totally frozen after these operations are performed and false if`
`6422`	`6422`	`* more freezing will eventually be required.`
`6423`	`6423`	`*`
`@@ -6445,7 +6445,7 @@ bool`
`6445`	`6445`	`heap_prepare_freeze_tuple(HeapTupleHeader tuple,`
`6446`	`6446`	`TransactionId relfrozenxid, TransactionId relminmxid,`
`6447`	`6447`	`TransactionId cutoff_xid, TransactionId cutoff_multi,`
`6448`		`- xl_heap_freeze_tuple frz, bool totally_frozen_p)`
	`6448`	`+ xl_heap_freeze_tuple frz, bool totally_frozen)`
`6449`	`6449`	`{`
`6450`	`6450`	`bool changed = false;`
`6451`	`6451`	`bool xmax_already_frozen = false;`
`@@ -6645,8 +6645,8 @@ heap_prepare_freeze_tuple(HeapTupleHeader tuple,`
`6645`	`6645`	`}`
`6646`	`6646`	`}`
`6647`	`6647`
`6648`		`- *totally_frozen_p = (xmin_frozen &&`
`6649`		`- (freeze_xmax \|\| xmax_already_frozen));`
	`6648`	`+ *totally_frozen = (xmin_frozen &&`
	`6649`	`+ (freeze_xmax \|\| xmax_already_frozen));`
`6650`	`6650`	`return changed;`
`6651`	`6651`	`}`
`6652`	`6652`