Silence perl critic

adunstan · adunstan · commit 5eabd91a83ad · 2025-03-15T17:41:54.000-04:00
Commit 27bdec0 uses a loop variable that is not strictly local to the loop. Perlcritic disapproves, and there's really no reason as the variable is not used outside the loop. Per buildfarm animals koel and crake.
diff --git a/src/common/unicode/generate-unicode_case_table.pl b/src/common/unicode/generate-unicode_case_table.pl
@@ -619,7 +619,7 @@ sub branch
 sub make_ranges
 {
 	my ($nums, $limit) = @_;
-	my ($prev, $start, $curr, $total, @sorted, @range);
+	my ($prev, $start, $total, @sorted, @range);
 
 	@sorted = sort { $a <=> $b } @$nums;
 
@@ -635,7 +635,7 @@ sub make_ranges
 	# append final 'undef' to signal final iteration
 	push @sorted, undef;
 
-	foreach $curr (@sorted)
+	foreach my $curr (@sorted)
 	{
 		# if last iteration always append the range
 		if (!defined($curr) || ($curr - $prev > $limit))

Original file line number	Diff line number	Diff line change
`@@ -619,7 +619,7 @@ sub branch`
`619`	`619`	`sub make_ranges`
`620`	`620`	`{`
`621`	`621`	`my ($nums, $limit) = @_;`
`622`		`- my ($prev, $start, $curr, $total, @sorted, @range);`
	`622`	`+ my ($prev, $start, $total, @sorted, @range);`
`623`	`623`
`624`	`624`	`@sorted = sort { $a <=> $b } @$nums;`
`625`	`625`
`@@ -635,7 +635,7 @@ sub make_ranges`
`635`	`635`	`# append final 'undef' to signal final iteration`
`636`	`636`	`push @sorted, undef;`
`637`	`637`
`638`		`- foreach $curr (@sorted)`
	`638`	`+ foreach my $curr (@sorted)`
`639`	`639`	`{`
`640`	`640`	`# if last iteration always append the range`
`641`	`641`	`if (!defined($curr) \|\| ($curr - $prev > $limit))`