Fix multiple bugs in numeric_poly_deserialize().

tglsfdc · tglsfdc · commit 600dc4c0da3b · 2016-09-03T14:18:55.000-04:00
These were evidently introduced by yesterday's commit 9cca11c, which perhaps needs more review than it got. Per report from Andreas Seltenreich and additional examination of nearby code. Report: <87oa45qfwq.fsf@credativ.de>
diff --git a/src/backend/utils/adt/numeric.c b/src/backend/utils/adt/numeric.c
@@ -4193,11 +4193,11 @@ numeric_poly_deserialize(PG_FUNCTION_ARGS)
 	accum_sum_add(&result->sumX, &sumX_var);
 #endif
 
-	set_var_from_num(DatumGetNumeric(sumX2), &sumX2_var);
+	init_var_from_num(DatumGetNumeric(sumX2), &sumX2_var);
 #ifdef HAVE_INT128
 	numericvar_to_int128(&sumX2_var, &result->sumX2);
 #else
-	accum_sum_add(&result->sumX2, &sumX_var);
+	accum_sum_add(&result->sumX2, &sumX2_var);
 #endif
 
 	pq_getmsgend(&buf);
