Skip to content

Commit 62bf0fb

Browse files
tvondratvondra
committed
Fix deserialization of pg_mcv_list values
There were multiple issues in deserialization of pg_mcv_list values. Firstly, the data is loaded from syscache, but the deserialization was performed after ReleaseSysCache(), at which point the data might have already disappeared. Fixed by moving the calls in statext_mcv_load, and using the same NULL-handling code as existing stats. Secondly, the deserialized representation used pointers into the serialized representation. But that is also unsafe, because the data may disappear at any time. Fixed by reworking and simplifying the deserialization code to always copy all the data. And thirdly, when deserializing values for types passed by value, the code simply did memcpy(d,s,typlen) which however does not work on bigendian machines. Fixed by using fetch_att/store_att_byval.
1 parent f3afbbd commit 62bf0fb

File tree

2 files changed

+207
-231
lines changed

2 files changed

+207
-231
lines changed

0 commit comments

Comments
 (0)