Skip to content

Commit 6435364

Browse files
tglsfdctglsfdc
committed
Mark to_char(timestamp without timezone) as stable, not immutable, since its
result now depends on the lc_messages setting, as noted by Bruce. Also, mark to_number() and the numeric-type variants of to_char() as stable, because their results depend on lc_numeric; this is a longstanding oversight. Also, mark to_date() and to_char(interval) as stable; although these appear not to depend on any GUC variables as of CVS HEAD, that seems a property unlikely to survive future improvements. It seems best to mark all the formatting functions stable and be done with it. catversion not bumped, because this does not seem critical enough to force a post-RC1 initdb, and anyway we cannot do so in the back branches.
1 parent a75ccd1 commit 6435364

File tree

1 file changed

+10
-10
lines changed

1 file changed

+10
-10
lines changed

‎src/include/catalog/pg_proc.h

+10-10
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* Portions Copyright (c) 1996-2006, PostgreSQL Global Development Group
88
* Portions Copyright (c) 1994, Regents of the University of California
99
*
10-
* $PostgreSQL: pgsql/src/include/catalog/pg_proc.h,v 1.428 2006/11/24 21:18:42 tgl Exp $
10+
* $PostgreSQL: pgsql/src/include/catalog/pg_proc.h,v 1.429 2006/11/28 19:18:44 tgl Exp $
1111
*
1212
* NOTES
1313
* The script catalog/genbki.sh reads this file and generates .bki
@@ -2614,23 +2614,23 @@ DESCR("(internal)");
26142614
/* formatting */
26152615
DATA(insert OID = 1770 ( to_char PGNSP PGUID 12 f f t f s 2 25 "1184 25" _null_ _null_ _null_ timestamptz_to_char - _null_ ));
26162616
DESCR("format timestamp with time zone to text");
2617-
DATA(insert OID = 1772 ( to_char PGNSP PGUID 12 f f t f i 2 25 "1700 25" _null_ _null_ _null_ numeric_to_char - _null_ ));
2617+
DATA(insert OID = 1772 ( to_char PGNSP PGUID 12 f f t f s 2 25 "1700 25" _null_ _null_ _null_ numeric_to_char - _null_ ));
26182618
DESCR("format numeric to text");
2619-
DATA(insert OID = 1773 ( to_char PGNSP PGUID 12 f f t f i 2 25 "23 25" _null_ _null_ _null_ int4_to_char - _null_ ));
2619+
DATA(insert OID = 1773 ( to_char PGNSP PGUID 12 f f t f s 2 25 "23 25" _null_ _null_ _null_ int4_to_char - _null_ ));
26202620
DESCR("format int4 to text");
2621-
DATA(insert OID = 1774 ( to_char PGNSP PGUID 12 f f t f i 2 25 "20 25" _null_ _null_ _null_ int8_to_char - _null_ ));
2621+
DATA(insert OID = 1774 ( to_char PGNSP PGUID 12 f f t f s 2 25 "20 25" _null_ _null_ _null_ int8_to_char - _null_ ));
26222622
DESCR("format int8 to text");
2623-
DATA(insert OID = 1775 ( to_char PGNSP PGUID 12 f f t f i 2 25 "700 25" _null_ _null_ _null_ float4_to_char - _null_ ));
2623+
DATA(insert OID = 1775 ( to_char PGNSP PGUID 12 f f t f s 2 25 "700 25" _null_ _null_ _null_ float4_to_char - _null_ ));
26242624
DESCR("format float4 to text");
2625-
DATA(insert OID = 1776 ( to_char PGNSP PGUID 12 f f t f i 2 25 "701 25" _null_ _null_ _null_ float8_to_char - _null_ ));
2625+
DATA(insert OID = 1776 ( to_char PGNSP PGUID 12 f f t f s 2 25 "701 25" _null_ _null_ _null_ float8_to_char - _null_ ));
26262626
DESCR("format float8 to text");
2627-
DATA(insert OID = 1777 ( to_number PGNSP PGUID 12 f f t f i 2 1700 "25 25" _null_ _null_ _null_ numeric_to_number - _null_ ));
2627+
DATA(insert OID = 1777 ( to_number PGNSP PGUID 12 f f t f s 2 1700 "25 25" _null_ _null_ _null_ numeric_to_number - _null_ ));
26282628
DESCR("convert text to numeric");
26292629
DATA(insert OID = 1778 ( to_timestamp PGNSP PGUID 12 f f t f s 2 1184 "25 25" _null_ _null_ _null_ to_timestamp - _null_ ));
26302630
DESCR("convert text to timestamp with time zone");
2631-
DATA(insert OID = 1780 ( to_date PGNSP PGUID 12 f f t f i 2 1082 "25 25" _null_ _null_ _null_ to_date - _null_ ));
2631+
DATA(insert OID = 1780 ( to_date PGNSP PGUID 12 f f t f s 2 1082 "25 25" _null_ _null_ _null_ to_date - _null_ ));
26322632
DESCR("convert text to date");
2633-
DATA(insert OID = 1768 ( to_char PGNSP PGUID 12 f f t f i 2 25 "1186 25" _null_ _null_ _null_ interval_to_char - _null_ ));
2633+
DATA(insert OID = 1768 ( to_char PGNSP PGUID 12 f f t f s 2 25 "1186 25" _null_ _null_ _null_ interval_to_char - _null_ ));
26342634
DESCR("format interval to text");
26352635

26362636
DATA(insert OID = 1282 ( quote_ident PGNSP PGUID 12 f f t f i 1 25 "25" _null_ _null_ _null_ quote_ident - _null_ ));
@@ -3035,7 +3035,7 @@ DATA(insert OID = 2047 ( timetz PGNSP PGUID 12 f f t f s 1 1266 "1083" _null_
30353035
DESCR("convert time to timetz");
30363036
DATA(insert OID = 2048 ( isfinite PGNSP PGUID 12 f f t f i 1 16 "1114" _null_ _null_ _null_ timestamp_finite - _null_ ));
30373037
DESCR("finite timestamp?");
3038-
DATA(insert OID = 2049 ( to_char PGNSP PGUID 12 f f t f i 2 25 "1114 25" _null_ _null_ _null_ timestamp_to_char - _null_ ));
3038+
DATA(insert OID = 2049 ( to_char PGNSP PGUID 12 f f t f s 2 25 "1114 25" _null_ _null_ _null_ timestamp_to_char - _null_ ));
30393039
DESCR("format timestamp to text");
30403040
DATA(insert OID = 2052 ( timestamp_eq PGNSP PGUID 12 f f t f i 2 16 "1114 1114" _null_ _null_ _null_ timestamp_eq - _null_ ));
30413041
DESCR("equal");

0 commit comments

Comments
 (0)