tests: Prevent syslog activity by slapd, take 2

anarazel · anarazel · commit 64470973b12a · 2023-03-16T23:07:29.000-07:00
Unfortunately it turns out that the logfile-only option added in b9f8d1c is only available in openldap starting in 2.6. Luckily the option to control the log level (loglevel/-s) have been around for much longer. As it turns out loglevel/-s only control what goes into syslog, not what ends up in the file specified with 'logfile' and stderr. While we currently are specifying 'logfile', nothing ends up in it, as the option only controls debug messages, and we didn't set a debug level. The debug level can only be configured on the commandline and also prevents forking. That'd require larger changes, so this commit doesn't tackle that issue. Specify the syslog level when starting slapd using -s, as that allows to prevent all syslog messages if one uses '0' instead of 'none', while loglevel doesn't prevent the first message. Discussion: https://postgr.es/m/20230311233708.3yjdbjkly2q4gq2j@awork3.anarazel.de Backpatch: 11-
diff --git a/src/test/ldap/LdapServer.pm b/src/test/ldap/LdapServer.pm
@@ -169,7 +169,6 @@ sub new
 
 		pidfile $slapd_pidfile
 		logfile $slapd_logfile
-		logfile-only on
 
 		access to *
 		        by * read
@@ -205,7 +204,8 @@ EOC
 	append_to_file($ldap_pwfile, $ldap_rootpw);
 	chmod 0600, $ldap_pwfile or die "chmod on $ldap_pwfile";
 
-	system_or_bail $slapd, '-f', $slapd_conf, '-h', "$ldap_url $ldaps_url";
+	# -s0 prevents log messages ending up in syslog
+	system_or_bail $slapd, '-f', $slapd_conf, '-s0', '-h', "$ldap_url $ldaps_url";
 
 	# wait until slapd accepts requests
 	my $retries = 0;
