Unbreak recovery test on Windows

adunstan · adunstan · commit 677271a3a125 · 2021-03-21T11:56:09.000-04:00
On Windows we need to send explicit quit messages to psql or the TAP tests
can hang.
diff --git a/src/test/recovery/t/022_crash_temp_files.pl b/src/test/recovery/t/022_crash_temp_files.pl
@@ -124,8 +124,10 @@ BEGIN
 my $ret = TestLib::system_log('pg_ctl', 'kill', 'KILL', $pid);
 is($ret, 0, 'killed process with KILL');
 
-# Close psql session
+# Explicitly shut down psql gracefully - to avoid hangs or worse on windows
+$killme_stdin .= "\\q\n";
 $killme->finish;
+$killme_stdin2 .= "\\q\n";
 $killme2->finish;
 
 # Wait till server restarts
@@ -212,8 +214,10 @@ BEGIN
 $ret = TestLib::system_log('pg_ctl', 'kill', 'KILL', $pid);
 is($ret, 0, 'killed process with KILL');
 
-# Close psql session
+# Explicitly shut down psql gracefully - to avoid hangs or worse on windows
+$killme_stdin .= "\\q\n";
 $killme->finish;
+$killme_stdin2 .= "\\q\n";
 $killme2->finish;
 
 # Wait till server restarts
