Add missing check for wal_debug GUC.

anarazel · anarazel · commit 67876a17eb36 · 2015-06-21T18:37:30.000+02:00
9a20a9b added a new elog(), enabled when WAL_DEBUG is defined. The other WAL_DEBUG dependant messages check for the wal_debug GUC, but this one did not. While at it replace 'upto' with 'up to'. Discussion: 20150610110253.GF3832@alap3.anarazel.de Backpatch to 9.4, the first release containing 9a20a9b.
diff --git a/src/backend/access/transam/xlog.c b/src/backend/access/transam/xlog.c
@@ -2255,9 +2255,9 @@ AdvanceXLInsertBuffer(XLogRecPtr upto, bool opportunistic)
 	LWLockRelease(WALBufMappingLock);
 
 #ifdef WAL_DEBUG
-	if (npages > 0)
+	if (XLOG_DEBUG && npages > 0)
 	{
-		elog(DEBUG1, "initialized %d pages, upto %X/%X",
+		elog(DEBUG1, "initialized %d pages, up to %X/%X",
 			 npages, (uint32) (NewPageEndPtr >> 32), (uint32) NewPageEndPtr);
 	}
 #endif

Original file line number	Diff line number	Diff line change
`@@ -2255,9 +2255,9 @@ AdvanceXLInsertBuffer(XLogRecPtr upto, bool opportunistic)`
`2255`	`2255`	`LWLockRelease(WALBufMappingLock);`
`2256`	`2256`
`2257`	`2257`	`#ifdef WAL_DEBUG`
`2258`		`- if (npages > 0)`
	`2258`	`+ if (XLOG_DEBUG && npages > 0)`
`2259`	`2259`	`{`
`2260`		`- elog(DEBUG1, "initialized %d pages, upto %X/%X",`
	`2260`	`+ elog(DEBUG1, "initialized %d pages, up to %X/%X",`
`2261`	`2261`	`npages, (uint32) (NewPageEndPtr >> 32), (uint32) NewPageEndPtr);`
`2262`	`2262`	`}`
`2263`	`2263`	`#endif`