Replace perror with custom postgres logging

danielgustafsson · danielgustafsson · commit 6929e133b309 · 2024-03-08T22:50:20.000+01:00
perror() is not used in postgres anymore out of policy, this replaces the final callsites with the custom postgres logging framework. Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us> Reviewed-by: Peter Eisentraut <peter@eisentraut.org> Discussion: https://postgr.es/m/89B00F63-40F7-4D82-8353-DC9CABBAC1D1@yesql.se
diff --git a/src/common/exec.c b/src/common/exec.c
@@ -378,7 +378,8 @@ pipe_read_line(char *cmd)
 	errno = 0;
 	if ((pipe_cmd = popen(cmd, "r")) == NULL)
 	{
-		perror("popen failure");
+		log_error(errcode(ERRCODE_SYSTEM_ERROR),
+				  _("could not execute command \"%s\": %m"), cmd);
 		return NULL;
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -378,7 +378,8 @@ pipe_read_line(char *cmd)`
`378`	`378`	`errno = 0;`
`379`	`379`	`if ((pipe_cmd = popen(cmd, "r")) == NULL)`
`380`	`380`	`{`
`381`		`- perror("popen failure");`
	`381`	`+ log_error(errcode(ERRCODE_SYSTEM_ERROR),`
	`382`	`+ _("could not execute command \"%s\": %m"), cmd);`
`382`	`383`	`return NULL;`
`383`	`384`	`}`
`384`	`385`