This patch removes the initialization of ri in loop in

bmomjian · bmomjian · commit 69d4299e3e53 · 2000-01-08T22:58:03.000Z
quote_postgres(...) in ecpglib.c.

The code in CVS reads:

quote_postgres(char *arg, int lineno)
{
 char    *res = (char *) ecpg_alloc(2 * strlen(arg) + 3, lineno);
 int   i,
    ri = 0;

 if (!res)
  return (res);

 res[ri++] = '\'';
 for (i = 0, ri=0; arg[i]; i++, ri++)
 {
  switch (arg[i])
  {
   case '\'':
    res[ri++] = '\'';
    break;
   case '\\':
    res[ri++] = '\\';
    break;
   default:
    ;
  }

The problem here is that ri is reset to 0, thus overwriting the initial
quote.

Stephen Birch
diff --git a/src/interfaces/ecpg/lib/ecpglib.c b/src/interfaces/ecpg/lib/ecpglib.c
@@ -238,7 +238,7 @@ quote_postgres(char *arg, int lineno)
 		return (res);
 
 	res[ri++] = '\'';
-	for (i = 0, ri = 0; arg[i]; i++, ri++)
+	for (i = 0; arg[i]; i++, ri++)
 	{
 		switch (arg[i])
 		{

Original file line number	Diff line number	Diff line change
`@@ -238,7 +238,7 @@ quote_postgres(char *arg, int lineno)`
`238`	`238`	`return (res);`
`239`	`239`
`240`	`240`	`res[ri++] = '\'';`
`241`		`- for (i = 0, ri = 0; arg[i]; i++, ri++)`
	`241`	`+ for (i = 0; arg[i]; i++, ri++)`
`242`	`242`	`{`
`243`	`243`	`switch (arg[i])`
`244`	`244`	`{`