Add missing newlines to PQescapeInternal() messages pre-v16.

tglsfdc · tglsfdc · commit 715241d71fa1 · 2025-05-01T17:36:47.000-04:00
While back-patching 9f45e6a, I neglected that the convention in pre-v16 libpq was to include a trailing newline in error message strings (since then, we add those separately). Add them now. Reported-by: Peter Eisentraut <peter@eisentraut.org> Discussion: https://postgr.es/m/a9c837ad-d507-4607-94e4-c5743a8f49e0@eisentraut.org Backpatch-through: 13-15
diff --git a/src/interfaces/libpq/fe-exec.c b/src/interfaces/libpq/fe-exec.c
@@ -4017,10 +4017,10 @@ PQescapeStringInternal(PGconn *conn,
 			{
 				if (remaining < charlen)
 					appendPQExpBufferStr(&conn->errorMessage,
-										 libpq_gettext("incomplete multibyte character"));
+										 libpq_gettext("incomplete multibyte character\n"));
 				else
 					appendPQExpBufferStr(&conn->errorMessage,
-										 libpq_gettext("invalid multibyte character"));
+										 libpq_gettext("invalid multibyte character\n"));
 				/* Issue a complaint only once per string */
 				already_complained = true;
 			}

Original file line number	Diff line number	Diff line change
`@@ -4017,10 +4017,10 @@ PQescapeStringInternal(PGconn *conn,`
`4017`	`4017`	`{`
`4018`	`4018`	`if (remaining < charlen)`
`4019`	`4019`	`appendPQExpBufferStr(&conn->errorMessage,`
`4020`		`- libpq_gettext("incomplete multibyte character"));`
	`4020`	`+ libpq_gettext("incomplete multibyte character\n"));`
`4021`	`4021`	`else`
`4022`	`4022`	`appendPQExpBufferStr(&conn->errorMessage,`
`4023`		`- libpq_gettext("invalid multibyte character"));`
	`4023`	`+ libpq_gettext("invalid multibyte character\n"));`
`4024`	`4024`	`/* Issue a complaint only once per string */`
`4025`	`4025`	`already_complained = true;`
`4026`	`4026`	`}`