Skip to content

Commit 777f50b

Browse files
committed
Stabilize 039_end_of_wal test.
The first test was sensitive to the insert LSN after setting up the catalogs, which depended on environmental things like the locales on the OS and usernames. Switch to a new WAL file before the first test, as a simple way to put every computer into the same state. Back-patch to all supported releases. Reported-by: Anton Voloshin <a.voloshin@postgrespro.ru> Reported-by: Nathan Bossart <nathandbossart@gmail.com> Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us> Reviewed-by: Nathan Bossart <nathandbossart@gmail.com> Discussion: https://postgr.es/m/b26aeac2-cb6d-4633-a7ea-945baae83dcf%40postgrespro.ru
1 parent 886549f commit 777f50b

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

src/test/recovery/t/039_end_of_wal.pl

+6
Original file line numberDiff line numberDiff line change
@@ -251,6 +251,12 @@ sub advance_to_record_splitting_zone
251251
$TLI = $node->safe_psql('postgres',
252252
"SELECT timeline_id FROM pg_control_checkpoint();");
253253

254+
# Initial LSN may vary across systems due to different catalog contents set up
255+
# by initdb. Switch to a new WAL file so all systems start out in the same
256+
# place. The first test depends on trailing zeroes on a page with a valid
257+
# header.
258+
$node->safe_psql('postgres', "SELECT pg_switch_wal();");
259+
254260
my $end_lsn;
255261
my $prev_lsn;
256262

0 commit comments

Comments
 (0)