Fix bug in the test of file descriptor of current WAL file in pg_receivexlog.

MasaoFujii · MasaoFujii · commit 78f91f1a8880 · 2014-11-19T19:11:03.000+09:00
In pg_receivexlog, in order to check whether the current WAL file is being opened or not, its file descriptor has to be checked against -1 as an invalid value. But, oops, 7900e94 added the incorrect test checking the descriptor against 1. This commit fixes that bug. Back-patch to 9.4 where the bug was added. Spotted by Magnus Hagander
diff --git a/src/bin/pg_basebackup/receivelog.c b/src/bin/pg_basebackup/receivelog.c
@@ -919,7 +919,7 @@ HandleCopyStream(PGconn *conn, XLogRecPtr startpos, uint32 timeline,
 			if (replyRequested && still_sending)
 			{
 				if (reportFlushPosition && lastFlushPosition < blockpos &&
-					walfile != 1)
+					walfile != -1)
 				{
 					/*
 					 * If a valid flush location needs to be reported,

Original file line number	Diff line number	Diff line change
`@@ -919,7 +919,7 @@ HandleCopyStream(PGconn *conn, XLogRecPtr startpos, uint32 timeline,`
`919`	`919`	`if (replyRequested && still_sending)`
`920`	`920`	`{`
`921`	`921`	`if (reportFlushPosition && lastFlushPosition < blockpos &&`
`922`		`- walfile != 1)`
	`922`	`+ walfile != -1)`
`923`	`923`	`{`
`924`	`924`	`/*`
`925`	`925`	`* If a valid flush location needs to be reported,`