Format better code for xact_decode()'s XLOG_XACT_INVALIDATIONS

michaelpq · michaelpq · commit 797adaf0febe · 2024-07-01T10:08:00.000+09:00
This makes the code more consistent with the surroundings. Author: ChangAo Chen Reviewed-by: Ashutosh Bapat Discussion: https://postgr.es/m/CAExHW5tNTevUh58SKddTtcX3yU_5_PDSC8Mdp-Q2hc9PpZHRJg@mail.gmail.com
diff --git a/src/backend/replication/logical/decode.c b/src/backend/replication/logical/decode.c
@@ -301,12 +301,13 @@ xact_decode(LogicalDecodingContext *ctx, XLogRecordBuffer *buf)
 					ReorderBufferXidSetCatalogChanges(ctx->reorder, xid,
 													  buf->origptr);
 				}
-				else if ((!ctx->fast_forward))
+				else if (!ctx->fast_forward)
 					ReorderBufferImmediateInvalidation(ctx->reorder,
 													   invals->nmsgs,
 													   invals->msgs);
+
+				break;
 			}
-			break;
 		case XLOG_XACT_PREPARE:
 			{
 				xl_xact_parsed_prepare parsed;

Original file line number	Diff line number	Diff line change
`@@ -301,12 +301,13 @@ xact_decode(LogicalDecodingContext ctx, XLogRecordBuffer buf)`
`301`	`301`	`ReorderBufferXidSetCatalogChanges(ctx->reorder, xid,`
`302`	`302`	`buf->origptr);`
`303`	`303`	`}`
`304`		`- else if ((!ctx->fast_forward))`
	`304`	`+ else if (!ctx->fast_forward)`
`305`	`305`	`ReorderBufferImmediateInvalidation(ctx->reorder,`
`306`	`306`	`invals->nmsgs,`
`307`	`307`	`invals->msgs);`
	`308`	`+`
	`309`	`+ break;`
`308`	`310`	`}`
`309`		`- break;`
`310`	`311`	`case XLOG_XACT_PREPARE:`
`311`	`312`	`{`
`312`	`313`	`xl_xact_parsed_prepare parsed;`