Suppress variable-set-but-not-used warnings from clang 15.

tglsfdc · tglsfdc · commit 85c077f9e022 · 2022-09-20T12:04:37.000-04:00
clang 15+ will issue a set-but-not-used warning when the only use of a variable is in autoincrements (e.g., "foo++;"). That's perfectly sensible, but it detects a few more cases that we'd not noticed before. Silence the warnings with our usual methods, such as PG_USED_FOR_ASSERTS_ONLY, or in one case by actually removing a useless variable. One thing that we can't nicely get rid of is that with %pure-parser, Bison emits "yynerrs" as a local variable that falls foul of this warning. To silence those, I inserted "(void) yynerrs;" in the top-level productions of affected grammars. Per recently-established project policy, this is a candidate for back-patching into out-of-support branches: it suppresses annoying compiler warnings but changes no behavior. Hence, back-patch to 9.5, which is as far as these patches go without issues. (A preliminary check shows that the prior branches need some other set-but-not-used cleanups too, so I'll leave them for another day.) Discussion: https://postgr.es/m/514615.1663615243@sss.pgh.pa.us
diff --git a/src/backend/access/gist/gistxlog.c b/src/backend/access/gist/gistxlog.c
@@ -255,7 +255,7 @@ gistRedoPageUpdateRecord(XLogReaderState *record)
 		char	   *begin;
 		char	   *data;
 		Size		datalen;
-		int			ninserted = 0;
+		int			ninserted PG_USED_FOR_ASSERTS_ONLY = 0;
 
 		data = begin = XLogRecGetBlockData(record, 0, &datalen);
 
diff --git a/src/backend/access/transam/xlog.c b/src/backend/access/transam/xlog.c
@@ -1923,7 +1923,7 @@ AdvanceXLInsertBuffer(XLogRecPtr upto, bool opportunistic)
 	XLogRecPtr	NewPageEndPtr = InvalidXLogRecPtr;
 	XLogRecPtr	NewPageBeginPtr;
 	XLogPageHeader NewPage;
-	int			npages = 0;
+	int			npages pg_attribute_unused() = 0;
 
 	LWLockAcquire(WALBufMappingLock, LW_EXCLUSIVE);
 
diff --git a/src/backend/parser/gram.y b/src/backend/parser/gram.y
@@ -734,6 +734,7 @@ static Node *makeRecursiveViewSelect(char *relname, List *aliases, Node *query);
 stmtblock:	stmtmulti
 			{
 				pg_yyget_extra(yyscanner)->parsetree = $1;
+				(void) yynerrs;		/* suppress compiler warning */
 			}
 		;
 
diff --git a/src/backend/utils/adt/array_typanalyze.c b/src/backend/utils/adt/array_typanalyze.c
@@ -216,7 +216,6 @@ compute_array_stats(VacAttrStats *stats, AnalyzeAttrFetchFunc fetchfunc,
 {
 	ArrayAnalyzeExtraData *extra_data;
 	int			num_mcelem;
-	int			null_cnt = 0;
 	int			null_elem_cnt = 0;
 	int			analyzed_rows = 0;
 
@@ -320,8 +319,7 @@ compute_array_stats(VacAttrStats *stats, AnalyzeAttrFetchFunc fetchfunc,
 		value = fetchfunc(stats, array_no, &isnull);
 		if (isnull)
 		{
-			/* array is null, just count that */
-			null_cnt++;
+			/* ignore arrays that are null overall */
 			continue;
 		}
 
diff --git a/src/bin/pgbench/exprparse.y b/src/bin/pgbench/exprparse.y
@@ -60,7 +60,10 @@ static PgBenchExpr *make_func(yyscan_t yyscanner, int fnumber, PgBenchExprList *
 
 %%
 
-result: expr				{ expr_parse_result = $1; }
+result: expr				{
+								expr_parse_result = $1;
+								(void) yynerrs; /* suppress compiler warning */
+							}
 
 elist:                  	{ $$ = NULL; }
 	| expr 					{ $$ = make_elist($1, NULL); }

Original file line number	Diff line number	Diff line change
`@@ -734,6 +734,7 @@ static Node makeRecursiveViewSelect(char relname, List aliases, Node query);`
`734`	`734`	`stmtblock: stmtmulti`
`735`	`735`	`{`
`736`	`736`	`pg_yyget_extra(yyscanner)->parsetree = $1;`
	`737`	`+ (void) yynerrs; /* suppress compiler warning */`
`737`	`738`	`}`
`738`	`739`	`;`
`739`	`740`
Original file line number	Diff line number	Diff line change
`@@ -216,7 +216,6 @@ compute_array_stats(VacAttrStats *stats, AnalyzeAttrFetchFunc fetchfunc,`
`216`	`216`	`{`
`217`	`217`	`ArrayAnalyzeExtraData *extra_data;`
`218`	`218`	`int num_mcelem;`
`219`		`- int null_cnt = 0;`
`220`	`219`	`int null_elem_cnt = 0;`
`221`	`220`	`int analyzed_rows = 0;`
`222`	`221`
`@@ -320,8 +319,7 @@ compute_array_stats(VacAttrStats *stats, AnalyzeAttrFetchFunc fetchfunc,`
`320`	`319`	`value = fetchfunc(stats, array_no, &isnull);`
`321`	`320`	`if (isnull)`
`322`	`321`	`{`
`323`		`- /* array is null, just count that */`
`324`		`- null_cnt++;`
	`322`	`+ /* ignore arrays that are null overall */`
`325`	`323`	`continue;`
`326`	`324`	`}`
`327`	`325`