Fix backwards test for Windows service-ness in pg_ctl.

tglsfdc · tglsfdc · commit 89f8372cb3a2 · 2016-03-07T10:40:57.000-05:00
A thinko in a967613 caused pg_ctl to get it exactly backwards when deciding whether to report problems to the Windows eventlog or to stderr. Per bug #14001 from Manuel Mathar, who also identified the fix. Like the previous patch, back-patch to all supported branches.
diff --git a/src/bin/pg_ctl/pg_ctl.c b/src/bin/pg_ctl/pg_ctl.c
@@ -223,7 +223,7 @@ write_stderr(const char *fmt,...)
 	 * On Win32, we print to stderr if running on a console, or write to
 	 * eventlog if running as a service
 	 */
-	if (!pgwin32_is_service())	/* Running as a service */
+	if (pgwin32_is_service())	/* Running as a service */
 	{
 		char		errbuf[2048];		/* Arbitrary size? */
 

Original file line number	Diff line number	Diff line change
`@@ -223,7 +223,7 @@ write_stderr(const char *fmt,...)`
`223`	`223`	`* On Win32, we print to stderr if running on a console, or write to`
`224`	`224`	`* eventlog if running as a service`
`225`	`225`	`*/`
`226`		`- if (!pgwin32_is_service()) /* Running as a service */`
	`226`	`+ if (pgwin32_is_service()) /* Running as a service */`
`227`	`227`	`{`
`228`	`228`	`char errbuf[2048]; /* Arbitrary size? */`
`229`	`229`