psql: call clearerr() just before printing

alvherre · alvherre · commit 8d645a116ef6 · 2021-03-29T18:34:39.000-03:00
We were never doing clearerr() on the output stream, which results in a message being printed after each result once an EOF is seen: could not print result table: Success This message was added by commit b034369 (in the pg13 era); before that, the error indicator would never be examined. So backpatch only that far back, even though the actual bug (to wit: the fact that the error indicator is never cleared) is older.
diff --git a/src/fe_utils/print.c b/src/fe_utils/print.c
@@ -3331,6 +3331,9 @@ printTable(const printTableContent *cont,
 		is_local_pager = is_pager;
 	}
 
+	/* clear any pre-existing error indication on the output stream */
+	clearerr(fout);
+
 	/* print the stuff */
 
 	if (flog)

Original file line number	Diff line number	Diff line change
`@@ -3331,6 +3331,9 @@ printTable(const printTableContent *cont,`
`3331`	`3331`	`is_local_pager = is_pager;`
`3332`	`3332`	`}`
`3333`	`3333`
	`3334`	`+ /* clear any pre-existing error indication on the output stream */`
	`3335`	`+ clearerr(fout);`
	`3336`	`+`
`3334`	`3337`	`/* print the stuff */`
`3335`	`3338`
`3336`	`3339`	`if (flog)`