Skip to content

Commit 905c020

Browse files
anarazelanarazel
committed
Add missing 'extern' to function prototypes.
Postgres style is to spell out extern. Noticed while scripting adding PGDLLIMPORT markers to functions. Discussion: https://postgr.es/m/20220512164513.vaheofqp2q24l65r@alap3.anarazel.de
1 parent c2f4361 commit 905c020

File tree

12 files changed

+70
-70
lines changed

12 files changed

+70
-70
lines changed

‎src/include/access/rewriteheap.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,6 @@ typedef struct LogicalRewriteMappingData
5252
* ---
5353
*/
5454
#define LOGICAL_REWRITE_FORMAT "map-%x-%x-%X_%X-%x-%x"
55-
void CheckPointLogicalRewriteHeap(void);
55+
extern void CheckPointLogicalRewriteHeap(void);
5656

5757
#endif /* REWRITE_HEAP_H */

‎src/include/port/win32_port.h

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -455,10 +455,10 @@ extern PGDLLIMPORT HANDLE pgwin32_initial_signal_pipe;
455455
#define UNBLOCKED_SIGNAL_QUEUE() (pg_signal_queue & ~pg_signal_mask)
456456
#define PG_SIGNAL_COUNT 32
457457

458-
void pgwin32_signal_initialize(void);
459-
HANDLE pgwin32_create_signal_listener(pid_t pid);
460-
void pgwin32_dispatch_queued_signals(void);
461-
void pg_queue_signal(int signum);
458+
extern void pgwin32_signal_initialize(void);
459+
extern HANDLE pgwin32_create_signal_listener(pid_t pid);
460+
extern void pgwin32_dispatch_queued_signals(void);
461+
extern void pg_queue_signal(int signum);
462462

463463
/* In src/port/kill.c */
464464
#define kill(pid,sig) pgkill(pid,sig)
@@ -475,15 +475,15 @@ extern int pgkill(int pid, int sig);
475475
#define recv(s, buf, len, flags) pgwin32_recv(s, buf, len, flags)
476476
#define send(s, buf, len, flags) pgwin32_send(s, buf, len, flags)
477477

478-
SOCKET pgwin32_socket(int af, int type, int protocol);
479-
int pgwin32_bind(SOCKET s, struct sockaddr *addr, int addrlen);
480-
int pgwin32_listen(SOCKET s, int backlog);
481-
SOCKET pgwin32_accept(SOCKET s, struct sockaddr *addr, int *addrlen);
482-
int pgwin32_connect(SOCKET s, const struct sockaddr *name, int namelen);
483-
int pgwin32_select(int nfds, fd_set *readfds, fd_set *writefds, fd_set *exceptfds, const struct timeval *timeout);
484-
int pgwin32_recv(SOCKET s, char *buf, int len, int flags);
485-
int pgwin32_send(SOCKET s, const void *buf, int len, int flags);
486-
int pgwin32_waitforsinglesocket(SOCKET s, int what, int timeout);
478+
extern SOCKET pgwin32_socket(int af, int type, int protocol);
479+
extern int pgwin32_bind(SOCKET s, struct sockaddr *addr, int addrlen);
480+
extern int pgwin32_listen(SOCKET s, int backlog);
481+
extern SOCKET pgwin32_accept(SOCKET s, struct sockaddr *addr, int *addrlen);
482+
extern int pgwin32_connect(SOCKET s, const struct sockaddr *name, int namelen);
483+
extern int pgwin32_select(int nfds, fd_set *readfds, fd_set *writefds, fd_set *exceptfds, const struct timeval *timeout);
484+
extern int pgwin32_recv(SOCKET s, char *buf, int len, int flags);
485+
extern int pgwin32_send(SOCKET s, const void *buf, int len, int flags);
486+
extern int pgwin32_waitforsinglesocket(SOCKET s, int what, int timeout);
487487

488488
extern PGDLLIMPORT int pgwin32_noblock;
489489

‎src/include/replication/message.h

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,8 @@ extern XLogRecPtr LogLogicalMessage(const char *prefix, const char *message,
3434

3535
/* RMGR API */
3636
#define XLOG_LOGICAL_MESSAGE 0x00
37-
void logicalmsg_redo(XLogReaderState *record);
38-
void logicalmsg_desc(StringInfo buf, XLogReaderState *record);
39-
const char *logicalmsg_identify(uint8 info);
37+
extern void logicalmsg_redo(XLogReaderState *record);
38+
extern void logicalmsg_desc(StringInfo buf, XLogReaderState *record);
39+
extern const char *logicalmsg_identify(uint8 info);
4040

4141
#endif /* PG_LOGICAL_MESSAGE_H */

‎src/include/replication/origin.h

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -62,9 +62,9 @@ extern void CheckPointReplicationOrigin(void);
6262
extern void StartupReplicationOrigin(void);
6363

6464
/* WAL logging */
65-
void replorigin_redo(XLogReaderState *record);
66-
void replorigin_desc(StringInfo buf, XLogReaderState *record);
67-
const char *replorigin_identify(uint8 info);
65+
extern void replorigin_redo(XLogReaderState *record);
66+
extern void replorigin_desc(StringInfo buf, XLogReaderState *record);
67+
extern const char *replorigin_identify(uint8 info);
6868

6969
/* shared memory allocation */
7070
extern Size ReplicationOriginShmemSize(void);

‎src/include/replication/reorderbuffer.h

Lines changed: 36 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -618,68 +618,68 @@ struct ReorderBuffer
618618
};
619619

620620

621-
ReorderBuffer *ReorderBufferAllocate(void);
622-
void ReorderBufferFree(ReorderBuffer *);
621+
extern ReorderBuffer *ReorderBufferAllocate(void);
622+
extern void ReorderBufferFree(ReorderBuffer *);
623623

624-
ReorderBufferTupleBuf *ReorderBufferGetTupleBuf(ReorderBuffer *, Size tuple_len);
625-
void ReorderBufferReturnTupleBuf(ReorderBuffer *, ReorderBufferTupleBuf *tuple);
626-
ReorderBufferChange *ReorderBufferGetChange(ReorderBuffer *);
627-
void ReorderBufferReturnChange(ReorderBuffer *, ReorderBufferChange *, bool);
624+
extern ReorderBufferTupleBuf *ReorderBufferGetTupleBuf(ReorderBuffer *, Size tuple_len);
625+
extern void ReorderBufferReturnTupleBuf(ReorderBuffer *, ReorderBufferTupleBuf *tuple);
626+
extern ReorderBufferChange *ReorderBufferGetChange(ReorderBuffer *);
627+
extern void ReorderBufferReturnChange(ReorderBuffer *, ReorderBufferChange *, bool);
628628

629-
Oid *ReorderBufferGetRelids(ReorderBuffer *, int nrelids);
630-
void ReorderBufferReturnRelids(ReorderBuffer *, Oid *relids);
629+
extern Oid *ReorderBufferGetRelids(ReorderBuffer *, int nrelids);
630+
extern void ReorderBufferReturnRelids(ReorderBuffer *, Oid *relids);
631631

632-
void ReorderBufferQueueChange(ReorderBuffer *, TransactionId,
632+
extern void ReorderBufferQueueChange(ReorderBuffer *, TransactionId,
633633
XLogRecPtr lsn, ReorderBufferChange *,
634634
bool toast_insert);
635-
void ReorderBufferQueueMessage(ReorderBuffer *, TransactionId, Snapshot snapshot, XLogRecPtr lsn,
635+
extern void ReorderBufferQueueMessage(ReorderBuffer *, TransactionId, Snapshot snapshot, XLogRecPtr lsn,
636636
bool transactional, const char *prefix,
637637
Size message_size, const char *message);
638-
void ReorderBufferCommit(ReorderBuffer *, TransactionId,
638+
extern void ReorderBufferCommit(ReorderBuffer *, TransactionId,
639639
XLogRecPtr commit_lsn, XLogRecPtr end_lsn,
640640
TimestampTz commit_time, RepOriginId origin_id, XLogRecPtr origin_lsn);
641-
void ReorderBufferFinishPrepared(ReorderBuffer *rb, TransactionId xid,
641+
extern void ReorderBufferFinishPrepared(ReorderBuffer *rb, TransactionId xid,
642642
XLogRecPtr commit_lsn, XLogRecPtr end_lsn,
643643
XLogRecPtr two_phase_at,
644644
TimestampTz commit_time,
645645
RepOriginId origin_id, XLogRecPtr origin_lsn,
646646
char *gid, bool is_commit);
647-
void ReorderBufferAssignChild(ReorderBuffer *, TransactionId, TransactionId, XLogRecPtr commit_lsn);
648-
void ReorderBufferCommitChild(ReorderBuffer *, TransactionId, TransactionId,
647+
extern void ReorderBufferAssignChild(ReorderBuffer *, TransactionId, TransactionId, XLogRecPtr commit_lsn);
648+
extern void ReorderBufferCommitChild(ReorderBuffer *, TransactionId, TransactionId,
649649
XLogRecPtr commit_lsn, XLogRecPtr end_lsn);
650-
void ReorderBufferAbort(ReorderBuffer *, TransactionId, XLogRecPtr lsn);
651-
void ReorderBufferAbortOld(ReorderBuffer *, TransactionId xid);
652-
void ReorderBufferForget(ReorderBuffer *, TransactionId, XLogRecPtr lsn);
653-
void ReorderBufferInvalidate(ReorderBuffer *, TransactionId, XLogRecPtr lsn);
654-
655-
void ReorderBufferSetBaseSnapshot(ReorderBuffer *, TransactionId, XLogRecPtr lsn, struct SnapshotData *snap);
656-
void ReorderBufferAddSnapshot(ReorderBuffer *, TransactionId, XLogRecPtr lsn, struct SnapshotData *snap);
657-
void ReorderBufferAddNewCommandId(ReorderBuffer *, TransactionId, XLogRecPtr lsn,
650+
extern void ReorderBufferAbort(ReorderBuffer *, TransactionId, XLogRecPtr lsn);
651+
extern void ReorderBufferAbortOld(ReorderBuffer *, TransactionId xid);
652+
extern void ReorderBufferForget(ReorderBuffer *, TransactionId, XLogRecPtr lsn);
653+
extern void ReorderBufferInvalidate(ReorderBuffer *, TransactionId, XLogRecPtr lsn);
654+
655+
extern void ReorderBufferSetBaseSnapshot(ReorderBuffer *, TransactionId, XLogRecPtr lsn, struct SnapshotData *snap);
656+
extern void ReorderBufferAddSnapshot(ReorderBuffer *, TransactionId, XLogRecPtr lsn, struct SnapshotData *snap);
657+
extern void ReorderBufferAddNewCommandId(ReorderBuffer *, TransactionId, XLogRecPtr lsn,
658658
CommandId cid);
659-
void ReorderBufferAddNewTupleCids(ReorderBuffer *, TransactionId, XLogRecPtr lsn,
659+
extern void ReorderBufferAddNewTupleCids(ReorderBuffer *, TransactionId, XLogRecPtr lsn,
660660
RelFileNode node, ItemPointerData pt,
661661
CommandId cmin, CommandId cmax, CommandId combocid);
662-
void ReorderBufferAddInvalidations(ReorderBuffer *, TransactionId, XLogRecPtr lsn,
662+
extern void ReorderBufferAddInvalidations(ReorderBuffer *, TransactionId, XLogRecPtr lsn,
663663
Size nmsgs, SharedInvalidationMessage *msgs);
664-
void ReorderBufferImmediateInvalidation(ReorderBuffer *, uint32 ninvalidations,
664+
extern void ReorderBufferImmediateInvalidation(ReorderBuffer *, uint32 ninvalidations,
665665
SharedInvalidationMessage *invalidations);
666-
void ReorderBufferProcessXid(ReorderBuffer *, TransactionId xid, XLogRecPtr lsn);
666+
extern void ReorderBufferProcessXid(ReorderBuffer *, TransactionId xid, XLogRecPtr lsn);
667667

668-
void ReorderBufferXidSetCatalogChanges(ReorderBuffer *, TransactionId xid, XLogRecPtr lsn);
669-
bool ReorderBufferXidHasCatalogChanges(ReorderBuffer *, TransactionId xid);
670-
bool ReorderBufferXidHasBaseSnapshot(ReorderBuffer *, TransactionId xid);
668+
extern void ReorderBufferXidSetCatalogChanges(ReorderBuffer *, TransactionId xid, XLogRecPtr lsn);
669+
extern bool ReorderBufferXidHasCatalogChanges(ReorderBuffer *, TransactionId xid);
670+
extern bool ReorderBufferXidHasBaseSnapshot(ReorderBuffer *, TransactionId xid);
671671

672-
bool ReorderBufferRememberPrepareInfo(ReorderBuffer *rb, TransactionId xid,
672+
extern bool ReorderBufferRememberPrepareInfo(ReorderBuffer *rb, TransactionId xid,
673673
XLogRecPtr prepare_lsn, XLogRecPtr end_lsn,
674674
TimestampTz prepare_time,
675675
RepOriginId origin_id, XLogRecPtr origin_lsn);
676-
void ReorderBufferSkipPrepare(ReorderBuffer *rb, TransactionId xid);
677-
void ReorderBufferPrepare(ReorderBuffer *rb, TransactionId xid, char *gid);
678-
ReorderBufferTXN *ReorderBufferGetOldestTXN(ReorderBuffer *);
679-
TransactionId ReorderBufferGetOldestXmin(ReorderBuffer *rb);
676+
extern void ReorderBufferSkipPrepare(ReorderBuffer *rb, TransactionId xid);
677+
extern void ReorderBufferPrepare(ReorderBuffer *rb, TransactionId xid, char *gid);
678+
extern ReorderBufferTXN *ReorderBufferGetOldestTXN(ReorderBuffer *);
679+
extern TransactionId ReorderBufferGetOldestXmin(ReorderBuffer *rb);
680680

681-
void ReorderBufferSetRestartPoint(ReorderBuffer *, XLogRecPtr ptr);
681+
extern void ReorderBufferSetRestartPoint(ReorderBuffer *, XLogRecPtr ptr);
682682

683-
void StartupReorderBuffer(void);
683+
extern void StartupReorderBuffer(void);
684684

685685
#endif

‎src/include/replication/worker_internal.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -99,8 +99,8 @@ extern char *LogicalRepSyncTableStart(XLogRecPtr *origin_startpos);
9999
extern bool AllTablesyncsReady(void);
100100
extern void UpdateTwoPhaseState(Oid suboid, char new_state);
101101

102-
void process_syncing_tables(XLogRecPtr current_lsn);
103-
void invalidate_syncing_table_states(Datum arg, int cacheid,
102+
extern void process_syncing_tables(XLogRecPtr current_lsn);
103+
extern void invalidate_syncing_table_states(Datum arg, int cacheid,
104104
uint32 hashvalue);
105105

106106
static inline bool

‎src/include/storage/s_lock.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1082,7 +1082,7 @@ init_spin_delay(SpinDelayStatus *status,
10821082
}
10831083

10841084
#define init_local_spin_delay(status) init_spin_delay(status, __FILE__, __LINE__, PG_FUNCNAME_MACRO)
1085-
void perform_spin_delay(SpinDelayStatus *status);
1086-
void finish_spin_delay(SpinDelayStatus *status);
1085+
extern void perform_spin_delay(SpinDelayStatus *status);
1086+
extern void finish_spin_delay(SpinDelayStatus *status);
10871087

10881088
#endif /* S_LOCK_H */

‎src/include/tsearch/dicts/regis.h

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -38,12 +38,12 @@ typedef struct Regis
3838
unused:15;
3939
} Regis;
4040

41-
bool RS_isRegis(const char *str);
41+
extern bool RS_isRegis(const char *str);
4242

43-
void RS_compile(Regis *r, bool issuffix, const char *str);
44-
void RS_free(Regis *r);
43+
extern void RS_compile(Regis *r, bool issuffix, const char *str);
44+
extern void RS_free(Regis *r);
4545

4646
/*returns true if matches */
47-
bool RS_execute(Regis *r, char *str);
47+
extern bool RS_execute(Regis *r, char *str);
4848

4949
#endif

‎src/include/utils/attoptcache.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,6 @@ typedef struct AttributeOpts
2323
float8 n_distinct_inherited;
2424
} AttributeOpts;
2525

26-
AttributeOpts *get_attribute_options(Oid spcid, int attnum);
26+
extern AttributeOpts *get_attribute_options(Oid spcid, int attnum);
2727

2828
#endif /* ATTOPTCACHE_H */

‎src/include/utils/numeric.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ typedef struct NumericData *Numeric;
6868
*/
6969
extern bool numeric_is_nan(Numeric num);
7070
extern bool numeric_is_inf(Numeric num);
71-
int32 numeric_maximum_size(int32 typmod);
71+
extern int32 numeric_maximum_size(int32 typmod);
7272
extern char *numeric_out_sci(Numeric num, int scale);
7373
extern char *numeric_normalize(Numeric num);
7474

‎src/include/utils/pgstat_internal.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -488,7 +488,7 @@ static inline void *pgstat_get_entry_data(PgStat_Kind kind, PgStatShared_Common
488488
* Functions in pgstat.c
489489
*/
490490

491-
const PgStat_KindInfo *pgstat_get_kind_info(PgStat_Kind kind);
491+
extern const PgStat_KindInfo *pgstat_get_kind_info(PgStat_Kind kind);
492492

493493
#ifdef USE_ASSERT_CHECKING
494494
extern void pgstat_assert_is_up(void);

‎src/include/utils/spccache.h

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,9 @@
1313
#ifndef SPCCACHE_H
1414
#define SPCCACHE_H
1515

16-
void get_tablespace_page_costs(Oid spcid, float8 *spc_random_page_cost,
16+
extern void get_tablespace_page_costs(Oid spcid, float8 *spc_random_page_cost,
1717
float8 *spc_seq_page_cost);
18-
int get_tablespace_io_concurrency(Oid spcid);
19-
int get_tablespace_maintenance_io_concurrency(Oid spcid);
18+
extern int get_tablespace_io_concurrency(Oid spcid);
19+
extern int get_tablespace_maintenance_io_concurrency(Oid spcid);
2020

2121
#endif /* SPCCACHE_H */

0 commit comments

Comments
 (0)