Remove redundant initialization of BrinMemTuple.

tglsfdc · tglsfdc · commit 913a03ec29ab · 2022-01-04T16:52:51.000-05:00
brin_new_memtuple already did this, so there's no need for initialize_brin_buildstate to do it again. Richard Guo, reviewed by Bharath Rupireddy Discussion: https://postgr.es/m/CAMbWs4-kYYpKNOdiWtsCZ3jbkFFj4nhOVH22JH7dsrMYX=aGjg@mail.gmail.com
diff --git a/src/backend/access/brin/brin.c b/src/backend/access/brin/brin.c
@@ -1262,8 +1262,6 @@ initialize_brin_buildstate(Relation idxRel, BrinRevmap *revmap,
 	state->bs_bdesc = brin_build_desc(idxRel);
 	state->bs_dtuple = brin_new_memtuple(state->bs_bdesc);
 
-	brin_memtuple_initialize(state->bs_dtuple, state->bs_bdesc);
-
 	return state;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -1262,8 +1262,6 @@ initialize_brin_buildstate(Relation idxRel, BrinRevmap *revmap,`
`1262`	`1262`	`state->bs_bdesc = brin_build_desc(idxRel);`
`1263`	`1263`	`state->bs_dtuple = brin_new_memtuple(state->bs_bdesc);`
`1264`	`1264`
`1265`		`- brin_memtuple_initialize(state->bs_dtuple, state->bs_bdesc);`
`1266`		`-`
`1267`	`1265`	`return state;`
`1268`	`1266`	`}`
`1269`	`1267`