Skip to content

Commit 928250a

Browse files
author
Michael Meskes
committed
Fix schedule of ecpg test files to only try two-phase commit test when possible.
1 parent f7819ba commit 928250a

File tree

2 files changed

+12
-2
lines changed

2 files changed

+12
-2
lines changed

src/interfaces/ecpg/test/Makefile

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,11 +78,22 @@ endif
7878
REGRESS_OPTS = --dbname=ecpg1_regression,ecpg2_regression --create-role=regress_ecpg_user1,regress_ecpg_user2 $(EXTRA_REGRESS_OPTS)
7979

8080
check: all
81-
$(with_temp_install) ./pg_regress $(REGRESS_OPTS) --temp-instance=./tmp_check $(TEMP_CONF) --bindir= $(pg_regress_locale_flags) $(THREAD) --schedule=$(srcdir)/ecpg_schedule
81+
$(with_temp_install) ./pg_regress $(REGRESS_OPTS) --temp-instance=./tmp_check $(TEMP_CONF) --bindir= $(pg_regress_locale_flags) $(THREAD) --schedule=$(srcdir)/ecpg_schedule sql/twophase
8282

8383
# the same options, but with --listen-on-tcp
8484
checktcp: all
8585
$(with_temp_install) ./pg_regress $(REGRESS_OPTS) --temp-instance=./tmp_check $(TEMP_CONF) --bindir= $(pg_regress_locale_flags) $(THREAD) --schedule=$(srcdir)/ecpg_schedule_tcp --host=localhost
8686

8787
installcheck: all
8888
./pg_regress $(REGRESS_OPTS) --bindir='$(bindir)' $(pg_regress_locale_flags) $(THREAD) --schedule=$(srcdir)/ecpg_schedule
89+
90+
# Versions of the check tests that include the twophase commit test.
91+
# It only makes sense to run these if set up to use prepared transactions,
92+
# via TEMP_CONFIG for the check case, or via the postgresql.conf for the
93+
# installcheck case.
94+
95+
installcheck-prepared-txns: all
96+
./pg_regress $(REGRESS_OPTS) --bindir='$(bindir)' $(pg_regress_locale_flags) $(THREAD) --schedule=$(srcdir)/ecpg_schedule sql/twophase
97+
98+
check-prepared-txns: all
99+
$(with_temp_install) ./pg_regress $(REGRESS_OPTS) --temp-instance=./tmp_check $(TEMP_CONF) --bindir= $(pg_regress_locale_flags) $(THREAD) --schedule=$(srcdir)/ecpg_schedule sql/twophase

src/interfaces/ecpg/test/ecpg_schedule

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,6 @@ test: sql/indicators
4646
test: sql/oldexec
4747
test: sql/quote
4848
test: sql/show
49-
test: sql/twophase
5049
test: sql/insupd
5150
test: sql/parser
5251
test: thread/thread

0 commit comments

Comments
 (0)