Skip to content

Commit 951dfa3

Browse files
committed
Remove tests that don't work on Windows.
On Windows, a filename cannot contain backslashes, because a backslash is used directory separator. Remove tests I added in commit 9c4f519 that tried to do that. We could perhaps use a SKIP block to only skip them on Windows, but I'm not sure how exactly to formulate that, so just remove the tests to make the buildfarm green again. Per buildfarm.
1 parent 3836d4b commit 951dfa3

File tree

1 file changed

+3
-11
lines changed

1 file changed

+3
-11
lines changed

src/bin/pg_rewind/t/003_extrafiles.pl

Lines changed: 3 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -46,16 +46,10 @@ sub run_test
4646
append_to_file
4747
"$test_standby_datadir/tst_standby_dir/standby_file4 with double\"quote",
4848
"in standby4";
49-
append_to_file
50-
"$test_standby_datadir/tst_standby_dir/standby_file5 with back\\slash",
51-
"in standby5";
52-
append_to_file
53-
"$test_standby_datadir/tst_standby_dir/standby_file6_with_backslash\\\"and_double-quote",
54-
"in standby6";
5549
mkdir "$test_standby_datadir/tst_standby_dir/standby_subdir/";
5650
append_to_file
57-
"$test_standby_datadir/tst_standby_dir/standby_subdir/standby_file7",
58-
"in standby7";
51+
"$test_standby_datadir/tst_standby_dir/standby_subdir/standby_file5",
52+
"in standby5";
5953

6054
mkdir "$test_primary_datadir/tst_primary_dir";
6155
append_to_file "$test_primary_datadir/tst_primary_dir/primary_file1",
@@ -94,10 +88,8 @@ sub run_test
9488
"$test_primary_datadir/tst_standby_dir/standby_file2",
9589
"$test_primary_datadir/tst_standby_dir/standby_file3 with 'quotes'",
9690
"$test_primary_datadir/tst_standby_dir/standby_file4 with double\"quote",
97-
"$test_primary_datadir/tst_standby_dir/standby_file5 with back\\slash",
98-
"$test_primary_datadir/tst_standby_dir/standby_file6_with_backslash\\\"and_double-quote",
9991
"$test_primary_datadir/tst_standby_dir/standby_subdir",
100-
"$test_primary_datadir/tst_standby_dir/standby_subdir/standby_file7"
92+
"$test_primary_datadir/tst_standby_dir/standby_subdir/standby_file5"
10193
],
10294
"file lists match");
10395

0 commit comments

Comments
 (0)