Don't assume that PageIsEmpty() returns true on an all-zeros page.

hlinnaka · hlinnaka · commit 9c88e06b5a24 · 2015-07-27T18:54:27.000+03:00
It does currently, and I don't see us changing that any time soon, but we
don't make that assumption anywhere else.

Per Tom Lane's suggestion. Backpatch to 9.2, like the previous patch that
added this assumption.
diff --git a/src/backend/access/spgist/spgvacuum.c b/src/backend/access/spgist/spgvacuum.c
@@ -655,7 +655,7 @@ spgvacuumpage(spgBulkDeleteState *bds, BlockNumber blkno)
 	 */
 	if (!SpGistBlockIsRoot(blkno))
 	{
-		if (PageIsEmpty(page))
+		if (PageIsNew(page) || PageIsEmpty(page))
 		{
 			RecordFreeIndexPage(index, blkno);
 			bds->stats->pages_deleted++;

Original file line number	Diff line number	Diff line change
`@@ -655,7 +655,7 @@ spgvacuumpage(spgBulkDeleteState *bds, BlockNumber blkno)`
`655`	`655`	`*/`
`656`	`656`	`if (!SpGistBlockIsRoot(blkno))`
`657`	`657`	`{`
`658`		`- if (PageIsEmpty(page))`
	`658`	`+ if (PageIsNew(page) \|\| PageIsEmpty(page))`
`659`	`659`	`{`
`660`	`660`	`RecordFreeIndexPage(index, blkno);`
`661`	`661`	`bds->stats->pages_deleted++;`