If they're not, the below causes problems, as the foreign key is added

bmomjian · bmomjian · commit a09ccc70dd78 · 2003-06-25T04:08:19.000Z
after the CHECK.  Cluster depends on the index name, so I thought it
wise to ensure all names are available, rather than leaving off the
CONSTRAINT "$n" portion for internally named constraints.

CREATE TABLE jkey (col integer primary key);
CREATE TABLE j (col integer REFERENCES jkey);
ALTER TABLE j ADD CHECK(col &gt; 5);

This is a problem in 7.3 series as well as -Tip.

Rod Taylor &lt;rbt@rbt.ca&gt;
diff --git a/src/bin/pg_dump/pg_dump.c b/src/bin/pg_dump/pg_dump.c
@@ -12,7 +12,7 @@
  *	by PostgreSQL
  *
  * IDENTIFICATION
- *	  $Header: /cvsroot/pgsql/src/bin/pg_dump/pg_dump.c,v 1.334 2003/06/25 03:56:31 momjian Exp $
+ *	  $Header: /cvsroot/pgsql/src/bin/pg_dump/pg_dump.c,v 1.335 2003/06/25 04:08:19 momjian Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -5347,8 +5347,7 @@ dumpOneTable(Archive *fout, TableInfo *tbinfo, TableInfo *g_tblinfo)
 				if (actual_atts + j > 0)
 					appendPQExpBuffer(q, ",\n    ");
 
-				if (name[0] != '$')
-					appendPQExpBuffer(q, "CONSTRAINT %s ",
+				appendPQExpBuffer(q, "CONSTRAINT %s ",
 									  fmtId(name));
 				appendPQExpBuffer(q, "%s", expr);
 			}

Original file line number	Diff line number	Diff line change
`@@ -12,7 +12,7 @@`
`12`	`12`	`* by PostgreSQL`
`13`	`13`	`*`
`14`	`14`	`* IDENTIFICATION`
`15`		`- * $Header: /cvsroot/pgsql/src/bin/pg_dump/pg_dump.c,v 1.334 2003/06/25 03:56:31 momjian Exp $`
	`15`	`+ * $Header: /cvsroot/pgsql/src/bin/pg_dump/pg_dump.c,v 1.335 2003/06/25 04:08:19 momjian Exp $`
`16`	`16`	`*`
`17`	`17`	`*-------------------------------------------------------------------------`
`18`	`18`	`*/`
`@@ -5347,8 +5347,7 @@ dumpOneTable(Archive fout, TableInfo tbinfo, TableInfo *g_tblinfo)`
`5347`	`5347`	`if (actual_atts + j > 0)`
`5348`	`5348`	`appendPQExpBuffer(q, ",\n ");`
`5349`	`5349`
`5350`		`- if (name[0] != '$')`
`5351`		`- appendPQExpBuffer(q, "CONSTRAINT %s ",`
	`5350`	`+ appendPQExpBuffer(q, "CONSTRAINT %s ",`
`5352`	`5351`	`fmtId(name));`
`5353`	`5352`	`appendPQExpBuffer(q, "%s", expr);`
`5354`	`5353`	`}`